Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove sender pool from map after closing #2101

Merged
merged 1 commit into from
Oct 10, 2018

Conversation

elbert3
Copy link
Contributor

@elbert3 elbert3 commented Oct 8, 2018

Remove sender pool from map after closing. This fixes an issue where the closed pool can get reused if the JMSServiceEventBus is restarted, for example when running multiple QA tests.

Related Issue
N/A

Signed-off-by: Elbert Evangelista <elbert.evangelista@eurotech.com>
@codecov
Copy link

codecov bot commented Oct 9, 2018

Codecov Report

Merging #2101 into develop will decrease coverage by 0.05%.
The diff coverage is 0%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #2101      +/-   ##
=============================================
- Coverage      57.29%   57.23%   -0.06%     
+ Complexity      1557     1555       -2     
=============================================
  Files           1057     1057              
  Lines          25761    25762       +1     
  Branches        2275     2275              
=============================================
- Hits           14759    14746      -13     
- Misses         10036    10047      +11     
- Partials         966      969       +3
Impacted Files Coverage Δ Complexity Δ
...se/kapua/commons/event/jms/JMSServiceEventBus.java 21.05% <0%> (-0.11%) 0 <0> (ø)
.../kura/kapua/TranslatorLifeDisconnectKuraKapua.java 62.96% <0%> (-29.63%) 6% <0%> (-1%)
...ua/broker/core/listener/DeviceMessageListener.java 33.33% <0%> (-8.89%) 0% <0%> (ø)
...broker/core/converter/KapuaLifeCycleConverter.java 61.11% <0%> (-5.56%) 0% <0%> (ø)
...ranslator/kura/kapua/TranslatorKuraKapuaUtils.java 56.66% <0%> (-3.34%) 2% <0%> (-1%)
...egistry/event/internal/DeviceEventServiceImpl.java 95.34% <0%> (-2.33%) 0% <0%> (ø)
...pse/kapua/broker/core/pool/JmsConsumerWrapper.java 70% <0%> (+10%) 0% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a94e177...12c414d. Read the comment docs.

@Coduz Coduz merged commit 2638a1c into eclipse-kapua:develop Oct 10, 2018
@Coduz Coduz added Bug This is a bug or an unexpected behaviour. Fix it! Test Test related stuff. It's a dirty job, but someone needs to do that! labels Sep 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug This is a bug or an unexpected behaviour. Fix it! Test Test related stuff. It's a dirty job, but someone needs to do that!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants