Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Role paging in Users fix #2189

Merged
merged 1 commit into from
Nov 19, 2018
Merged

Role paging in Users fix #2189

merged 1 commit into from
Nov 19, 2018

Conversation

ct-ajovanovic
Copy link
Contributor

Signed-off-by: ct-ajovanovic aleksandra.jovanovic@comtrade.com

Brief description of the PR.
Role paging in Users fix

Related Issue
This PR fixes/closes #2174

Description of the solution adopted
The totalLegnth property in GwtAccessRoleServiceImpl class is now always set to int value of accessRoleService.count(query). This is one of the properties the EntityGrid's entityLoader needs for correct result display.

Screenshots
None

Any side note on the changes made
Added accessRoleList.isEmpty() check in findByUserId() method of GwtAccessRoleServiceImpl class .

Signed-off-by: ct-ajovanovic <aleksandra.jovanovic@comtrade.com>
@LeoNerdoG
Copy link
Contributor

I have verified that this issue successfully resolves issue #2174.

@codecov
Copy link

codecov bot commented Nov 19, 2018

Codecov Report

Merging #2189 into develop will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #2189      +/-   ##
=============================================
+ Coverage      57.43%   57.45%   +0.01%     
  Complexity      1584     1584              
=============================================
  Files           1068     1068              
  Lines          25978    25978              
  Branches        2296     2296              
=============================================
+ Hits           14920    14925       +5     
+ Misses         10082    10078       -4     
+ Partials         976      975       -1
Impacted Files Coverage Δ Complexity Δ
...pse/kapua/broker/core/pool/JmsConsumerWrapper.java 60% <0%> (-10%) 0% <0%> (ø)
.../broker/core/plugin/KapuaSecurityBrokerFilter.java 75.32% <0%> (+0.32%) 0% <0%> (ø) ⬇️
...plugin/authentication/UserAuthenticationLogic.java 73.39% <0%> (+1.83%) 0% <0%> (ø) ⬇️
...egistry/event/internal/DeviceEventServiceImpl.java 97.67% <0%> (+2.32%) 0% <0%> (ø) ⬇️
...ua/broker/core/listener/DeviceMessageListener.java 48.88% <0%> (+6.66%) 0% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ffc750...db11ac4. Read the comment docs.

@muros-ct muros-ct merged commit 99180aa into eclipse-kapua:develop Nov 19, 2018
Coduz pushed a commit that referenced this pull request Nov 23, 2018
Signed-off-by: ct-ajovanovic <aleksandra.jovanovic@comtrade.com>
@ct-ajovanovic ct-ajovanovic deleted the fix-issue2174 branch August 20, 2019 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Role Paging In Users Not Working Properly
3 participants