Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix descriptions for Devices Configurations methods in SwaggerUI #2233

Conversation

lorthirk
Copy link

@lorthirk lorthirk commented Dec 6, 2018

Just a small fix for a few descriptions in Devices resource (Configuration methods specifically) in SwaggerUI

Related Issue
This PR fixes #2229

@Coduz
Copy link
Contributor

Coduz commented Dec 7, 2018

Please rebase on the latest develop

Signed-off-by: Claudio Mezzasalma <claudio.mezzasalma@eurotech.com>
@Coduz Coduz force-pushed the fix-swaggerDeviceConfigurationDescription branch from 67d2c22 to 064a173 Compare December 7, 2018 13:23
@codecov
Copy link

codecov bot commented Dec 7, 2018

Codecov Report

Merging #2233 into develop will increase coverage by 0.11%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             develop   #2233      +/-   ##
============================================
+ Coverage      57.29%   57.4%   +0.11%     
  Complexity      1584    1584              
============================================
  Files           1071    1071              
  Lines          26010   26010              
  Branches        2299    2299              
============================================
+ Hits           14902   14932      +30     
+ Misses         10133   10096      -37     
- Partials         975     982       +7
Impacted Files Coverage Δ Complexity Δ
...ua/broker/core/listener/DeviceMessageListener.java 42.22% <0%> (-6.67%) 0% <0%> (ø)
...plugin/authentication/UserAuthenticationLogic.java 73.63% <0%> (-1.82%) 0% <0%> (ø)
.../broker/core/plugin/KapuaSecurityBrokerFilter.java 74.75% <0%> (-0.33%) 0% <0%> (ø)
...a/kura/simulator/generator/GeneratorScheduler.java 78.12% <0%> (+18.75%) 0% <0%> (ø) ⬇️
...ipse/kapua/kura/simulator/generator/Generator.java 100% <0%> (+33.33%) 0% <0%> (ø) ⬇️
...pua/kura/simulator/app/data/PeriodicGenerator.java 61.4% <0%> (+36.84%) 0% <0%> (ø) ⬇️
...clipse/kapua/kura/simulator/generator/Payload.java 50% <0%> (+50%) 0% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6462174...064a173. Read the comment docs.

@Coduz Coduz merged commit 1bf0330 into eclipse-kapua:develop Dec 10, 2018
@lorthirk lorthirk deleted the fix-swaggerDeviceConfigurationDescription branch January 25, 2019 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

devices/configurations REST endpoints have wrong descriptions in SwaggerUI
2 participants