Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature job execution log #2343

Merged
merged 4 commits into from
Mar 27, 2019
Merged

Feature job execution log #2343

merged 4 commits into from
Mar 27, 2019

Conversation

Coduz
Copy link
Contributor

@Coduz Coduz commented Jan 29, 2019

This PR adds the JobExecution log.

Related Issue
None

Description of the solution adopted
Now the log done in the Job processing using JobLogger is splitted between the JobExecution and the standard application logging.

Still missing the console dialog to show it.

Screenshots
None

Any side note on the changes made
This PR is based on feature-jobTargetErrorMessage which has its own PR #2342

@Coduz Coduz added the Enhancement This PR/Issue improves an part of Kapua label Jan 29, 2019
@Coduz Coduz force-pushed the feature-jobExecutionLog branch from 8b910ea to 5f94d49 Compare January 29, 2019 15:01
@codecov
Copy link

codecov bot commented Jan 29, 2019

Codecov Report

Merging #2343 into develop will increase coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #2343      +/-   ##
=============================================
+ Coverage      56.08%   56.09%   +0.01%     
  Complexity      1501     1501              
=============================================
  Files           1068     1068              
  Lines          25835    25839       +4     
  Branches        2322     2322              
=============================================
+ Hits           14489    14494       +5     
+ Misses         10364    10363       -1     
  Partials         982      982
Impacted Files Coverage Δ Complexity Δ
...ipse/kapua/service/job/execution/JobExecution.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...rvice/job/execution/internal/JobExecutionImpl.java 42.85% <0%> (-5.53%) 9 <0> (ø)
...plugin/authentication/UserAuthenticationLogic.java 74.79% <0%> (+1.62%) 0% <0%> (ø) ⬇️
...ua/broker/core/listener/DeviceMessageListener.java 48.88% <0%> (+6.66%) 0% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2362a6f...944f671. Read the comment docs.

@Coduz Coduz force-pushed the feature-jobExecutionLog branch 3 times, most recently from 487ff56 to 47312c9 Compare February 11, 2019 14:18
@Coduz Coduz force-pushed the feature-jobExecutionLog branch from 47312c9 to 720f858 Compare February 15, 2019 11:14
@Coduz Coduz changed the base branch from develop to feature-jobTargetErrorMessage February 15, 2019 14:43
@Coduz Coduz force-pushed the feature-jobTargetErrorMessage branch from b6df775 to 14da2a3 Compare March 4, 2019 13:31
@Coduz Coduz force-pushed the feature-jobExecutionLog branch from 720f858 to 4ea813d Compare March 4, 2019 13:32
@Coduz Coduz force-pushed the feature-jobTargetErrorMessage branch from 14da2a3 to 8ae6320 Compare March 22, 2019 13:12
@Coduz Coduz force-pushed the feature-jobExecutionLog branch from 4ea813d to f4ff08c Compare March 22, 2019 13:13
@Coduz Coduz force-pushed the feature-jobTargetErrorMessage branch from 8ae6320 to 50d26c6 Compare March 25, 2019 14:14
@Coduz Coduz force-pushed the feature-jobExecutionLog branch from f4ff08c to b152abb Compare March 25, 2019 14:19
@Coduz Coduz force-pushed the feature-jobTargetErrorMessage branch from 50d26c6 to c041650 Compare March 26, 2019 10:39
@Coduz Coduz changed the base branch from feature-jobTargetErrorMessage to develop March 26, 2019 13:00
Coduz added 3 commits March 26, 2019 14:07
Signed-off-by: coduz <alberto.codutti@eurotech.com>
Signed-off-by: coduz <alberto.codutti@eurotech.com>
Signed-off-by: coduz <alberto.codutti@eurotech.com>
@Coduz Coduz force-pushed the feature-jobExecutionLog branch from b152abb to dbd30c2 Compare March 26, 2019 13:10
Signed-off-by: coduz <alberto.codutti@eurotech.com>
@Coduz Coduz merged commit 15b6468 into develop Mar 27, 2019
@Coduz Coduz deleted the feature-jobExecutionLog branch March 27, 2019 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement This PR/Issue improves an part of Kapua
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant