-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature job execution log #2343
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coduz
force-pushed
the
feature-jobExecutionLog
branch
from
January 29, 2019 15:01
8b910ea
to
5f94d49
Compare
Codecov Report
@@ Coverage Diff @@
## develop #2343 +/- ##
=============================================
+ Coverage 56.08% 56.09% +0.01%
Complexity 1501 1501
=============================================
Files 1068 1068
Lines 25835 25839 +4
Branches 2322 2322
=============================================
+ Hits 14489 14494 +5
+ Misses 10364 10363 -1
Partials 982 982
Continue to review full report at Codecov.
|
Coduz
force-pushed
the
feature-jobExecutionLog
branch
3 times, most recently
from
February 11, 2019 14:18
487ff56
to
47312c9
Compare
Coduz
force-pushed
the
feature-jobExecutionLog
branch
from
February 15, 2019 11:14
47312c9
to
720f858
Compare
Coduz
force-pushed
the
feature-jobTargetErrorMessage
branch
from
March 4, 2019 13:31
b6df775
to
14da2a3
Compare
Coduz
force-pushed
the
feature-jobExecutionLog
branch
from
March 4, 2019 13:32
720f858
to
4ea813d
Compare
Coduz
force-pushed
the
feature-jobTargetErrorMessage
branch
from
March 22, 2019 13:12
14da2a3
to
8ae6320
Compare
Coduz
force-pushed
the
feature-jobExecutionLog
branch
from
March 22, 2019 13:13
4ea813d
to
f4ff08c
Compare
Coduz
force-pushed
the
feature-jobTargetErrorMessage
branch
from
March 25, 2019 14:14
8ae6320
to
50d26c6
Compare
Coduz
force-pushed
the
feature-jobExecutionLog
branch
from
March 25, 2019 14:19
f4ff08c
to
b152abb
Compare
Coduz
force-pushed
the
feature-jobTargetErrorMessage
branch
from
March 26, 2019 10:39
50d26c6
to
c041650
Compare
Signed-off-by: coduz <alberto.codutti@eurotech.com>
Signed-off-by: coduz <alberto.codutti@eurotech.com>
Signed-off-by: coduz <alberto.codutti@eurotech.com>
Coduz
force-pushed
the
feature-jobExecutionLog
branch
from
March 26, 2019 13:10
b152abb
to
dbd30c2
Compare
Signed-off-by: coduz <alberto.codutti@eurotech.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
JobExecution
log.Related Issue
None
Description of the solution adopted
Now the log done in the
Job
processing usingJobLogger
is splitted between the JobExecution and the standard application logging.Still missing the console dialog to show it.
Screenshots
None
Any side note on the changes made
This PR is based on
feature-jobTargetErrorMessage
which has its own PR #2342