Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature device operation provided #2416

Merged
merged 4 commits into from
Apr 2, 2019
Merged

Conversation

Coduz
Copy link
Contributor

@Coduz Coduz commented Feb 18, 2019

Added the capability for the user to provide a operationId for the DeviceManagementOperation linked to the device management operation

Related Issue
None

Description of the solution adopted
Changed the DevicePackageManagement API to deprecate the current signatures:

 KapuaId downloadExec(KapuaId scopeId, KapuaId deviceId, DevicePackageDownloadRequest packageDownloadRequest, Long timeout) throws KapuaException;
 KapuaId installExec(KapuaId scopeId, KapuaId deviceId, DevicePackageInstallRequest packageInstallRequest, Long timeout) throws KapuaException;
 KapuaId uninstallExec(KapuaId scopeId, KapuaId deviceId, DevicePackageUninstallRequest packageUninstallRequest, Long timeout) throws KapuaException;

switching to

 KapuaId downloadExec(KapuaId scopeId, KapuaId deviceId, DevicePackageDownloadRequest packageDownloadRequest, DevicePackageDownloadOptions devicePackageDownloadOptions) throws KapuaException;
 KapuaId installExec(KapuaId scopeId, KapuaId deviceId, DevicePackageInstallRequest packageInstallRequest, DevicePackageInstallOptions devicePackageInstallOptions) throws KapuaException;
 KapuaId uninstallExec(KapuaId scopeId, KapuaId deviceId, DevicePackageUninstallRequest packageUninstallRequest, DevicePackageUninstallOptions devicePackageUninstallOptions) throws KapuaException;

Screenshots
None

Any side note on the changes made
Javadoc and small code improvements applied.

@Coduz Coduz added the Enhancement This PR/Issue improves an part of Kapua label Feb 26, 2019
@Coduz Coduz force-pushed the feature-jobEnqueuing branch from b96f163 to d6b7122 Compare March 4, 2019 13:33
@Coduz Coduz force-pushed the feature-deviceOperationProvidedId branch from c3ba237 to 80869b4 Compare March 4, 2019 13:36
@codecov
Copy link

codecov bot commented Mar 4, 2019

Codecov Report

Merging #2416 into develop will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #2416      +/-   ##
=============================================
+ Coverage      56.05%   56.05%   +<.01%     
  Complexity      1501     1501              
=============================================
  Files           1073     1073              
  Lines          25852    25854       +2     
  Branches        2322     2322              
=============================================
+ Hits           14491    14493       +2     
  Misses         10379    10379              
  Partials         982      982
Impacted Files Coverage Δ Complexity Δ
...t/commons/AbstractDeviceManagementServiceImpl.java 73.07% <100%> (+1.07%) 0 <0> (ø) ⬇️
...pse/kapua/broker/core/pool/JmsConsumerWrapper.java 60% <0%> (-10%) 0% <0%> (ø)
...plugin/authentication/UserAuthenticationLogic.java 74.79% <0%> (+1.62%) 0% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1630314...e2921ea. Read the comment docs.

@Coduz Coduz force-pushed the feature-jobEnqueuing branch from d6b7122 to 87f4a4e Compare March 22, 2019 13:15
@Coduz Coduz force-pushed the feature-deviceOperationProvidedId branch from 80869b4 to 7af375e Compare March 22, 2019 13:17
@Coduz Coduz force-pushed the feature-jobEnqueuing branch from 87f4a4e to f8248ec Compare March 25, 2019 14:50
@Coduz Coduz force-pushed the feature-deviceOperationProvidedId branch from 7af375e to 1abd193 Compare March 25, 2019 15:00
@Coduz Coduz force-pushed the feature-jobEnqueuing branch 2 times, most recently from 6b290b9 to 450de1f Compare March 28, 2019 14:08
@Coduz Coduz force-pushed the feature-deviceOperationProvidedId branch 2 times, most recently from cfb5000 to 02400d2 Compare March 29, 2019 08:49
@Coduz Coduz changed the base branch from feature-jobEnqueuing to develop March 29, 2019 08:50
Coduz added 3 commits April 1, 2019 17:32
Signed-off-by: coduz <alberto.codutti@eurotech.com>
Signed-off-by: coduz <alberto.codutti@eurotech.com>
… in PackageManagementService

Signed-off-by: coduz <alberto.codutti@eurotech.com>
@Coduz Coduz force-pushed the feature-deviceOperationProvidedId branch from 02400d2 to 8c0551d Compare April 1, 2019 15:32
Signed-off-by: coduz <alberto.codutti@eurotech.com>
@Coduz Coduz merged commit 6f62b7a into develop Apr 2, 2019
@Coduz Coduz deleted the feature-deviceOperationProvidedId branch April 2, 2019 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement This PR/Issue improves an part of Kapua
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant