Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed missing QueryParam in DeviceConnections.simpleQuery() #2429

Merged

Conversation

lorthirk
Copy link

A @QueryParam annotation was missing for the clientId in DeviceConnections.simpleQuery() REST API. This PR fixes it.

Related Issue
No related issues

Description of the solution adopted
N/A

Screenshots
N/A

Any side note on the changes made
N/A

Signed-off-by: Claudio Mezzasalma <claudio.mezzasalma@eurotech.com>
@lorthirk lorthirk added Bug This is a bug or an unexpected behaviour. Fix it! REST API We hope to REST everyday labels Feb 20, 2019
@lorthirk lorthirk requested a review from Coduz February 20, 2019 13:21
@codecov
Copy link

codecov bot commented Feb 20, 2019

Codecov Report

Merging #2429 into develop will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #2429      +/-   ##
=============================================
- Coverage       55.4%   55.39%   -0.01%     
  Complexity      1536     1536              
=============================================
  Files           1092     1092              
  Lines          26491    26491              
  Branches        2346     2346              
=============================================
- Hits           14677    14676       -1     
- Misses         10825    10827       +2     
+ Partials         989      988       -1
Impacted Files Coverage Δ Complexity Δ
...ua/broker/core/listener/DeviceMessageListener.java 42.22% <0%> (-6.67%) 0% <0%> (ø)
...ation/shiro/realm/UserPassAuthenticatingRealm.java 71.3% <0%> (+1.73%) 0% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6e8148...5f668d7. Read the comment docs.

@Coduz Coduz merged commit 5d93ac3 into eclipse-kapua:develop Feb 26, 2019
@lorthirk lorthirk deleted the fix-missingQueryParamDeviceConnections branch April 10, 2019 07:25
@lorthirk lorthirk restored the fix-missingQueryParamDeviceConnections branch April 10, 2019 07:25
@lorthirk lorthirk deleted the fix-missingQueryParamDeviceConnections branch April 10, 2019 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug This is a bug or an unexpected behaviour. Fix it! REST API We hope to REST everyday
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants