Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature job delete forced #2626

Merged
merged 2 commits into from
Jun 28, 2019
Merged

Conversation

Coduz
Copy link
Contributor

@Coduz Coduz commented Jun 21, 2019

This PR add the feature to delete a job forcing the check on the job status.

Related Issue
None

Description of the solution adopted
Added a new methods that ignores exceptions when requesting the JobEngineService to clean up data. This can be used when for some reasons the job gets stuck and a regular delete is failing because the Job is running on the JobEngine.

This feature is only available to the sys administrator.

Screenshots
None

Any side note on the changes made
None

@Coduz Coduz added the Enhancement This PR/Issue improves an part of Kapua label Jun 21, 2019
@Coduz Coduz requested a review from lorthirk June 21, 2019 13:58
@codecov
Copy link

codecov bot commented Jun 21, 2019

Codecov Report

Merging #2626 into develop will increase coverage by 0.63%.
The diff coverage is 25%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #2626      +/-   ##
=============================================
+ Coverage      48.85%   49.49%   +0.63%     
- Complexity      2450     2481      +31     
=============================================
  Files            992      992              
  Lines          28134    28145      +11     
  Branches        2308     2311       +3     
=============================================
+ Hits           13744    13929     +185     
+ Misses         13409    13234     -175     
- Partials         981      982       +1
Impacted Files Coverage Δ Complexity Δ
...apua/job/engine/jbatch/JobEngineServiceJbatch.java 15.74% <ø> (ø) 3 <0> (ø) ⬇️
...a/job/engine/jbatch/listener/KapuaJobListener.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...pse/kapua/service/job/internal/JobServiceImpl.java 80.26% <42.85%> (-8.97%) 20 <2> (+1)
.../service/device/call/message/kura/KuraPayload.java 47.68% <0%> (+1.32%) 24% <0%> (ø) ⬇️
...ore/plugin/authentication/AuthenticationLogic.java 90.62% <0%> (+1.56%) 0% <0%> (ø) ⬇️
...n/java/org/eclipse/kapua/qa/common/Suppressed.java 50% <0%> (+1.72%) 11% <0%> (ø) ⬇️
...n/java/org/eclipse/kapua/qa/common/BasicSteps.java 51.61% <0%> (+3.22%) 14% <0%> (+1%) ⬆️
.../broker/core/plugin/KapuaSecurityBrokerFilter.java 74.6% <0%> (+3.8%) 0% <0%> (ø) ⬇️
...egistry/event/internal/DeviceEventServiceImpl.java 44.89% <0%> (+4.08%) 6% <0%> (+1%) ⬆️
...plugin/authentication/UserAuthenticationLogic.java 74.79% <0%> (+5.69%) 0% <0%> (ø) ⬇️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7c58c2...2fe94b4. Read the comment docs.

@Coduz Coduz changed the title Feature job delete forces Feature job delete forced Jun 25, 2019
@Coduz Coduz force-pushed the feature-jobDeleteForced branch 2 times, most recently from 7255889 to 6f02ea1 Compare June 27, 2019 12:25
Coduz added 2 commits June 28, 2019 11:58
Signed-off-by: coduz <alberto.codutti@eurotech.com>
Signed-off-by: coduz <alberto.codutti@eurotech.com>
@Coduz Coduz force-pushed the feature-jobDeleteForced branch from 6f02ea1 to 2fe94b4 Compare June 28, 2019 09:58
@Coduz Coduz merged commit 0439443 into eclipse-kapua:develop Jun 28, 2019
@Coduz Coduz deleted the feature-jobDeleteForced branch June 28, 2019 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement This PR/Issue improves an part of Kapua
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants