Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Cucumber Testing Specific Information #2649

Merged
merged 1 commit into from
Jul 12, 2019

Conversation

LeoNerdoG
Copy link
Contributor

I have added cucumber specifics for kapua project. All of the information
is added in qa.md file, as I did not want to add a new file.
There is basic information regarding testing and after that some
specific information for potential developers/QA people that would want to
contribute.

Related Issue
This PR fixes issue #2648.

Description of the solution adopted
I have added documentation regarding cucumber integration testing in /docs/developer/guide/qa.md.

Screenshots
N/A

Any side note on the changes made
There are no side notes that need explanation since this is just a simpel documentation describing cucumber integration tests.

Signed-off-by: Leonardo Gaube leonardo.gaube@comtrade.com

@Coduz Coduz added Documentation Doc... What?? Joke! We will write some! Test Test related stuff. It's a dirty job, but someone needs to do that! labels Jul 10, 2019
@codecov
Copy link

codecov bot commented Jul 10, 2019

Codecov Report

Merging #2649 into develop will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #2649      +/-   ##
=============================================
+ Coverage      50.14%   50.15%   +0.01%     
- Complexity      2551     2552       +1     
=============================================
  Files           1000     1000              
  Lines          28241    28241              
  Branches        2308     2308              
=============================================
+ Hits           14162    14165       +3     
+ Misses         13081    13079       -2     
+ Partials         998      997       -1
Impacted Files Coverage Δ Complexity Δ
...pse/kapua/broker/core/pool/JmsConsumerWrapper.java 60% <0%> (-10%) 0% <0%> (ø)
...egistry/event/internal/DeviceEventServiceImpl.java 44.89% <0%> (+4.08%) 6% <0%> (+1%) ⬆️
...ua/broker/core/listener/DeviceMessageListener.java 53.19% <0%> (+6.38%) 0% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4b7858...7474d3a. Read the comment docs.

@codecov
Copy link

codecov bot commented Jul 10, 2019

Codecov Report

Merging #2649 into develop will increase coverage by 0.86%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #2649      +/-   ##
=============================================
+ Coverage      49.76%   50.62%   +0.86%     
- Complexity      2509     2586      +77     
=============================================
  Files           1001     1001              
  Lines          28503    28503              
  Branches        2317     2317              
=============================================
+ Hits           14184    14431     +247     
+ Misses         13342    13070     -272     
- Partials         977     1002      +25
Impacted Files Coverage Δ Complexity Δ
...pse/kapua/broker/core/pool/JmsConsumerWrapper.java 60% <0%> (-10%) 0% <0%> (ø)
...nnection/internal/DeviceConnectionServiceImpl.java 45.56% <0%> (-2.54%) 10% <0%> (-1%)
...pse/kapua/commons/service/internal/ServiceDAO.java 68.64% <0%> (+1.04%) 0% <0%> (ø) ⬇️
.../eclipse/kapua/qa/common/SimulatedDeviceSteps.java 94.24% <0%> (+1.04%) 60% <0%> (ø) ⬇️
.../broker/core/plugin/KapuaSecurityBrokerFilter.java 74.6% <0%> (+1.26%) 0% <0%> (ø) ⬇️
...e/kapua/broker/core/plugin/metric/LoginMetric.java 86.66% <0%> (+2.22%) 0% <0%> (ø) ⬇️
.../org/eclipse/kapua/qa/common/cucumber/CucUser.java 42.85% <0%> (+2.38%) 12% <0%> (+1%) ⬆️
...lipse/kapua/kura/simulator/MqttAsyncTransport.java 55.55% <0%> (+2.77%) 0% <0%> (ø) ⬇️
...n/java/org/eclipse/kapua/qa/common/Suppressed.java 50% <0%> (+3.44%) 11% <0%> (+1%) ⬆️
...lator/kura/kapua/TranslatorLifeBirthKuraKapua.java 96.36% <0%> (+3.63%) 7% <0%> (+1%) ⬆️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c85a852...6bbb6cd. Read the comment docs.

1. Run `mvn clean install -DskipTests -Pconsole,docker` and then `mvn clean install` command to see if all the tests pass correctly
2. Push changes to you remote repository and wait for the Travis to complete successfully (there should be no test failures, CI environments should always be green):
- Travis CI [![Build](https://api.travis-ci.org/eclipse/kapua.svg)](https://travis-ci.org/eclipse/kapua/)
- Eclipse Hudson [![Hudson](https://img.shields.io/jenkins/s/https/hudson.eclipse.org/kapua/job/Develop.svg)](https://hudson.eclipse.org/kapua/)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make references to Jenkins since Hudson has been deprecated.
Use link https://ci.eclipse.org/kapua/

2. Push changes to you remote repository and wait for the Travis to complete successfully (there should be no test failures, CI environments should always be green):
- Travis CI [![Build](https://api.travis-ci.org/eclipse/kapua.svg)](https://travis-ci.org/eclipse/kapua/)
- Eclipse Hudson [![Hudson](https://img.shields.io/jenkins/s/https/hudson.eclipse.org/kapua/job/Develop.svg)](https://hudson.eclipse.org/kapua/)
3. Test OpenShift distribution: You should also verify that OpenShift regression test suite works as expected.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't we removed the qa-openshift module?


You should also verify that OpenShift regression test suite works as expected. First of all, start local OpenShift cluster as described
[here](https://github.com/eclipse/kapua/blob/develop/docs/developer-guide/en/running.md#openshift).
Go to [IntelliJ website](https://www.jetbrains.com/idea/download/#section=mac) and download the Community Edition IntelliJ. After the installation, we have to install some plugins also, but not before we install Java and Maven.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe remove the #section=mac and make just point to the download page

docs/developer-guide/en/qa.md Show resolved Hide resolved
### Testing In General

#### Unit testing
Unit testing is simpe testing, that tests small chunks of code (for example user creation), that do not use other services (permissions, devices...). These tests are tipically done by developers as they know the functionality best.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

simpe typo

@LeoNerdoG LeoNerdoG force-pushed the kapua-i9n-tests-explained branch from 7474d3a to 4e59f32 Compare July 12, 2019 06:25
I have added cucumber specifics for kapua project. All of the information
is added in qa.md file, as I did not want to add a new file.
There is basic information regarding testing and after that some
specific information for potential developers/QA people that would want to
contribute.
"qa-openshift" testing par thas been removed, since this module is not in
the project any more.

Signed-off-by: Leonardo Gaube <leonardo.gaube@comtrade.com>
@LeoNerdoG LeoNerdoG force-pushed the kapua-i9n-tests-explained branch from 4e59f32 to 6bbb6cd Compare July 12, 2019 06:36
@LeoNerdoG
Copy link
Contributor Author

Hey @Coduz,
I have commited and pushed the changes. Please merge when tests complete.

@Coduz Coduz merged commit 2f08795 into eclipse-kapua:develop Jul 12, 2019
@LeoNerdoG LeoNerdoG deleted the kapua-i9n-tests-explained branch October 1, 2019 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Doc... What?? Joke! We will write some! Test Test related stuff. It's a dirty job, but someone needs to do that!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants