Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add useSsl and additional options to MariaDB connection string #2684

Merged
merged 1 commit into from
Aug 27, 2019

Conversation

lorthirk
Copy link

According to #2681, the commons.db.connection.useSsl option is not honored from the MariaDB connector. This PR fixes it, and it also adds a generic commons.db.connection.additionalOptions to use as a last resort if other options are needed, also in other JdbcConnectionUrlResolvers.

Related Issue
This PR fixes #2681

Signed-off-by: Claudio Mezzasalma <claudio.mezzasalma@eurotech.com>
@codecov
Copy link

codecov bot commented Aug 22, 2019

Codecov Report

Merging #2684 into develop will decrease coverage by 0.15%.
The diff coverage is 12.5%.

Impacted file tree graph

@@             Coverage Diff              @@
##             develop   #2684      +/-   ##
============================================
- Coverage      53.76%   53.6%   -0.16%     
+ Complexity      2924    2918       -6     
============================================
  Files           1035    1035              
  Lines          28999   29022      +23     
  Branches        2330    2333       +3     
============================================
- Hits           15591   15557      -34     
- Misses         12338   12397      +59     
+ Partials        1070    1068       -2
Impacted Files Coverage Δ Complexity Δ
.../DefaultConfigurableJdbcConnectionUrlResolver.java 0% <0%> (ø) 0 <0> (ø) ⬇️
.../commons/jpa/MariaDBJdbcConnectionUrlResolver.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...kapua/commons/setting/system/SystemSettingKey.java 100% <100%> (ø) 0 <0> (ø) ⬇️
.../kapua/commons/jpa/JdbcConnectionUrlResolvers.java 45.45% <20%> (+6.99%) 0 <0> (ø) ⬇️
...kapua/commons/jpa/H2JdbcConnectionUrlResolver.java 70% <33.33%> (-15.72%) 0 <0> (ø)
...pse/kapua/transport/mqtt/MqttClientErrorCodes.java 0% <0%> (-100%) 0% <0%> (-1%)
...ipse/kapua/transport/mqtt/MqttClientException.java 0% <0%> (-28.58%) 0% <0%> (-1%)
...ransport/mqtt/pooling/PooledMqttClientFactory.java 63.33% <0%> (-23.34%) 4% <0%> (-2%)
...a/org/eclipse/kapua/transport/mqtt/MqttClient.java 51.28% <0%> (-11.54%) 12% <0%> (-1%)
...egistry/event/internal/DeviceEventServiceImpl.java 78.72% <0%> (-8.52%) 13% <0%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ae5564...07fe95d. Read the comment docs.

@lorthirk lorthirk requested a review from Coduz August 26, 2019 07:46
@Coduz Coduz merged commit 950f6e4 into eclipse-kapua:develop Aug 27, 2019
@lorthirk lorthirk deleted the fix-dbConnectionStringSsl branch September 16, 2019 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

commons.db.connection.useSsl setting not honored
2 participants