Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature service configuration rest #2732

Merged

Conversation

lorthirk
Copy link

@lorthirk lorthirk commented Oct 7, 2019

This PR introduces a new set of REST APIs to manage Service Configurations.

The APIs are:

  • GET /{scopeId}/serviceConfigurations: Retrieve all the services configurations for a given account
  • PUT /{scopeId}/serviceConfigurations: Update multiple services configurations for a given account
  • GET /{scopeId}/serviceConfigurations/{serviceId}: Retrieve the service configuration for a given account and a given service
  • PUT /{scopeId}/serviceConfigurations/{serviceId}: Update the service configuration for a given account and a given service

Related Issue
No related issues

@lorthirk lorthirk added Enhancement This PR/Issue improves an part of Kapua REST API We hope to REST everyday labels Oct 7, 2019
@lorthirk lorthirk requested a review from Coduz October 7, 2019 15:21
@lorthirk lorthirk force-pushed the feature-serviceConfigurationRest branch from 96e9305 to 50d4d4e Compare October 18, 2019 13:24
@codecov
Copy link

codecov bot commented Oct 18, 2019

Codecov Report

❗ No coverage uploaded for pull request base (develop@d826f1c). Click here to learn what that means.
The diff coverage is 2.47%.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #2732   +/-   ##
==========================================
  Coverage           ?   57.35%           
  Complexity         ?     3158           
==========================================
  Files              ?     1077           
  Lines              ?    30496           
  Branches           ?     2418           
==========================================
  Hits               ?    17492           
  Misses             ?    11846           
  Partials           ?     1158
Impacted Files Coverage Δ Complexity Δ
...nfiguration/ServiceComponentConfigurationImpl.java 0% <0%> (ø) 0 <0> (?)
...ommons/configuration/ServiceConfigurationImpl.java 0% <0%> (ø) 0 <0> (?)
...ervice/config/ServiceXmlConfigPropertyAdapted.java 0% <0%> (ø) 0 <0> (?)
...onfiguration/AbstractKapuaConfigurableService.java 80% <0%> (ø) 0 <0> (?)
...vice/config/ServiceXmlConfigPropertiesAdapted.java 0% <0%> (ø) 0 <0> (?)
...vice/config/ServiceXmlConfigPropertiesAdapter.java 0% <0%> (ø) 0 <0> (?)
...ervice/config/ServiceConfigurationXmlRegistry.java 0% <0%> (ø) 0 <0> (?)
...configuration/ServiceConfigurationFactoryImpl.java 0% <0%> (ø) 0 <0> (?)
...astore/internal/MetricInfoRegistryServiceImpl.java 82.55% <100%> (ø) 6 <1> (?)
...astore/internal/ClientInfoRegistryServiceImpl.java 82.14% <100%> (ø) 6 <1> (?)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d826f1c...caf5b71. Read the comment docs.

@lorthirk lorthirk force-pushed the feature-serviceConfigurationRest branch from 401b0b4 to 3e283a4 Compare November 13, 2019 15:59
Claudio Mezzasalma added 5 commits November 13, 2019 16:59
Signed-off-by: Claudio Mezzasalma <claudio.mezzasalma@eurotech.com>
Signed-off-by: Claudio Mezzasalma <claudio.mezzasalma@eurotech.com>
Signed-off-by: Claudio Mezzasalma <claudio.mezzasalma@eurotech.com>
…gurable

Signed-off-by: Claudio Mezzasalma <claudio.mezzasalma@eurotech.com>
Signed-off-by: Claudio Mezzasalma <claudio.mezzasalma@eurotech.com>
@lorthirk lorthirk force-pushed the feature-serviceConfigurationRest branch from 3e283a4 to 870e4a3 Compare November 13, 2019 16:00
Signed-off-by: Claudio Mezzasalma <claudio.mezzasalma@eurotech.com>
@lorthirk lorthirk force-pushed the feature-serviceConfigurationRest branch from 870e4a3 to caf5b71 Compare November 13, 2019 16:06
@Coduz Coduz merged commit 44dffb5 into eclipse-kapua:develop Nov 14, 2019
@lorthirk lorthirk deleted the feature-serviceConfigurationRest branch December 4, 2019 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement This PR/Issue improves an part of Kapua REST API We hope to REST everyday
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants