Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separated tests for job engine service - restart job #2742

Merged

Conversation

ct-anaalbic
Copy link
Contributor

Signed-off-by: Ana Albic ana.albic@comtrade.com

Brief description of the PR.
Separated tests for restarting job in job engine service.

Related Issue
This PR fixes/closes {issue number}

Description of the solution adopted
In this PR, test scenarios for restarting job with online device/devices are separated in two .feature files. Also, in job restart steps with wait are changed and in some scenarios wait is increased to 30 seconds instead of 15 seconds.

Screenshots
/

Any side note on the changes made
/

@codecov
Copy link

codecov bot commented Oct 18, 2019

Codecov Report

Merging #2742 into develop will decrease coverage by 0.1%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #2742      +/-   ##
=============================================
- Coverage      54.57%   54.46%   -0.11%     
+ Complexity      3108     3104       -4     
=============================================
  Files           1049     1049              
  Lines          29813    29813              
  Branches        2387     2387              
=============================================
- Hits           16269    16239      -30     
- Misses         12424    12455      +31     
+ Partials        1120     1119       -1
Impacted Files Coverage Δ Complexity Δ
...pse/kapua/transport/mqtt/MqttClientErrorCodes.java 0% <0%> (-100%) 0% <0%> (-1%)
...ipse/kapua/transport/mqtt/MqttClientException.java 0% <0%> (-28.58%) 0% <0%> (-1%)
...ransport/mqtt/pooling/PooledMqttClientFactory.java 80% <0%> (-10%) 6% <0%> (ø)
...a/org/eclipse/kapua/transport/mqtt/MqttClient.java 61.53% <0%> (-6.42%) 14% <0%> (ø)
...clipse/kapua/commons/jpa/EntityManagerSession.java 64.35% <0%> (-2.98%) 0% <0%> (ø)
...nnection/internal/DeviceConnectionServiceImpl.java 58.44% <0%> (-2.6%) 12% <0%> (-1%)
...a/service/device/registry/internal/DeviceImpl.java 64.44% <0%> (-0.75%) 57% <0%> (-1%)
...pse/kapua/commons/service/internal/ServiceDAO.java 74.21% <0%> (-0.35%) 0% <0%> (ø)
...lugin/authentication/AdminAuthenticationLogic.java 76.92% <0%> (+7.69%) 0% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1fd6145...67ca11f. Read the comment docs.

Signed-off-by: Ana Albic <ana.albic@comtrade.com>
@ct-anaalbic ct-anaalbic force-pushed the separatedTestsForRestartingJob branch from 25b8978 to 67ca11f Compare October 18, 2019 07:49
@Coduz Coduz merged commit ab8cccb into eclipse-kapua:develop Oct 18, 2019
@Coduz Coduz added the Test Test related stuff. It's a dirty job, but someone needs to do that! label Oct 21, 2019
@ct-anaalbic ct-anaalbic deleted the separatedTestsForRestartingJob branch December 17, 2019 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Test Test related stuff. It's a dirty job, but someone needs to do that!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants