Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fallback to byte array for non-Kura body payload #2745

Merged
merged 1 commit into from
Oct 21, 2019

Conversation

lorthirk
Copy link

Currently, if a message is sent to the broker that does not conform to the Kura Protobuf specification, that message is discarded. With this PR it will be stored anyway instead, with the raw payload in the body.

Related Issue
No related issue

@lorthirk lorthirk added the Bug This is a bug or an unexpected behaviour. Fix it! label Oct 18, 2019
@lorthirk lorthirk requested a review from Coduz October 18, 2019 09:01
@codecov
Copy link

codecov bot commented Oct 18, 2019

Codecov Report

Merging #2745 into develop will decrease coverage by 0.02%.
The diff coverage is 0%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #2745      +/-   ##
=============================================
- Coverage      54.53%   54.51%   -0.03%     
+ Complexity      2990     2370     -620     
=============================================
  Files           1049     1049              
  Lines          29813    29816       +3     
  Branches        2387     2387              
=============================================
- Hits           16259    16254       -5     
- Misses         12435    12441       +6     
- Partials        1119     1121       +2
Impacted Files Coverage Δ Complexity Δ
...a/translator/mqtt/kura/TranslatorDataMqttKura.java 18.75% <0%> (-4.33%) 3 <0> (ø)
...ua/broker/core/listener/DeviceMessageListener.java 46.8% <0%> (-6.39%) 0% <0%> (ø)
...egistry/event/internal/DeviceEventServiceImpl.java 69.38% <0%> (-4.09%) 6% <0%> (-5%)
...e/registry/internal/DeviceRegistryServiceImpl.java 48.43% <0%> (-3.13%) 13% <0%> (-3%)
...service/datastore/internal/MessageStoreFacade.java 49.1% <0%> (+0.44%) 11% <0%> (-5%) ⬇️
...translator/kura/kapua/TranslatorDataKuraKapua.java 85.29% <0%> (+2.94%) 7% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab8cccb...848868a. Read the comment docs.

Signed-off-by: Claudio Mezzasalma <claudio.mezzasalma@eurotech.com>
@Coduz Coduz merged commit 74dc7b7 into eclipse-kapua:develop Oct 21, 2019
@lorthirk lorthirk deleted the fix-nonKuraPayload branch January 24, 2020 09:22
@lorthirk lorthirk restored the fix-nonKuraPayload branch January 24, 2020 09:23
@lorthirk lorthirk deleted the fix-nonKuraPayload branch January 24, 2020 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug This is a bug or an unexpected behaviour. Fix it!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants