Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes in Device Management Notification service #2777

Merged
merged 2 commits into from
Nov 19, 2019

Conversation

Coduz
Copy link
Contributor

@Coduz Coduz commented Nov 18, 2019

This PR fixes small problems found on the Device management notification service.

Related Issue
None

Description of the solution adopted
Fixes performed:

  • Removed duplicate classes (Xml Registries classes)
  • Removed unused OperationStatus in kapua-device-call-api module.

Screenshots
None

Any side note on the changes made
None

Signed-off-by: coduz <alberto.codutti@eurotech.com>
@Coduz Coduz added the Bug This is a bug or an unexpected behaviour. Fix it! label Nov 18, 2019
@Coduz Coduz requested a review from lorthirk November 18, 2019 14:01
@codecov
Copy link

codecov bot commented Nov 18, 2019

Codecov Report

Merging #2777 into develop will decrease coverage by 0.1%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #2777      +/-   ##
=============================================
- Coverage      57.11%   57.01%   -0.11%     
+ Complexity      3138     3115      -23     
=============================================
  Files           1077     1074       -3     
  Lines          30514    30495      -19     
  Branches        2423     2423              
=============================================
- Hits           17428    17386      -42     
- Misses         11933    11954      +21     
- Partials        1153     1155       +2
Impacted Files Coverage Δ Complexity Δ
...pse/kapua/transport/mqtt/MqttClientErrorCodes.java 0% <0%> (-100%) 0% <0%> (-1%)
...ne/queue/jbatch/QueuedJobExecutionCreatorImpl.java 0% <0%> (-100%) 0% <0%> (-9%)
...ob/engine/queue/jbatch/QueuedJobExecutionImpl.java 9.09% <0%> (-54.55%) 1% <0%> (-7%)
...job/engine/queue/jbatch/QueuedJobExecutionDAO.java 6.66% <0%> (-53.34%) 1% <0%> (-2%)
...e/jbatch/listener/QueuedJobExecutionCheckTask.java 58.06% <0%> (-29.04%) 4% <0%> (-3%)
...ipse/kapua/transport/mqtt/MqttClientException.java 0% <0%> (-28.58%) 0% <0%> (-1%)
...ne/queue/jbatch/QueuedJobExecutionServiceImpl.java 25% <0%> (-25%) 4% <0%> (-4%)
...ages/job/AbstractDevicePackageTargetProcessor.java 46.66% <0%> (-23.34%) 5% <0%> (-2%)
...a/job/engine/jbatch/listener/KapuaJobListener.java 75.69% <0%> (-14.59%) 22% <0%> (-6%)
...e/kapua/job/engine/jbatch/driver/JbatchDriver.java 56.3% <0%> (-12.61%) 14% <0%> (-6%)
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a263b0d...acb8c8d. Read the comment docs.

Signed-off-by: coduz <alberto.codutti@eurotech.com>
@Coduz Coduz force-pushed the fix-duplicatesXmlRegistry branch from 02927d3 to acb8c8d Compare November 19, 2019 09:25
@Coduz Coduz merged commit 41852c7 into eclipse-kapua:develop Nov 19, 2019
@Coduz Coduz deleted the fix-duplicatesXmlRegistry branch November 19, 2019 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug This is a bug or an unexpected behaviour. Fix it!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants