Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix device management lifecycle APPS message processing #2780

Merged

Conversation

Coduz
Copy link
Contributor

@Coduz Coduz commented Nov 20, 2019

Fixed the processing of the APP message from the DeviceLifecycleService.

Related Issue
None

Description of the solution adopted
On the processing of the APPS message from the service, the Device info update was missing and only the lastEvent was updated.

Now the service stores correctly updated device infos from the APPS message.

Screenshots
None

Any side note on the changes made
I've also performed a small improvement of the code

@Coduz Coduz added the Bug This is a bug or an unexpected behaviour. Fix it! label Nov 20, 2019
@Coduz Coduz force-pushed the fix-deviceManagementLifecycleService branch from 63f9573 to ab2fa81 Compare November 21, 2019 10:38
@codecov
Copy link

codecov bot commented Nov 21, 2019

Codecov Report

Merging #2780 into develop will increase coverage by 0.45%.
The diff coverage is 74.19%.

Impacted file tree graph

@@             Coverage Diff              @@
##             develop   #2780      +/-   ##
============================================
+ Coverage      57.04%   57.5%   +0.45%     
- Complexity      3120    3166      +46     
============================================
  Files           1074    1074              
  Lines          30502   30474      -28     
  Branches        2427    2427              
============================================
+ Hits           17400   17523     +123     
+ Misses         11940   11788     -152     
- Partials        1162    1163       +1
Impacted Files Coverage Δ Complexity Δ
...lifecycle/internal/DeviceLifeCycleServiceImpl.java 79.16% <74.19%> (+16.26%) 10 <6> (+3) ⬆️
...egistry/event/internal/DeviceEventServiceImpl.java 80.35% <0%> (+3.57%) 14% <0%> (+1%) ⬆️
...a/org/eclipse/kapua/transport/mqtt/MqttClient.java 67.94% <0%> (+6.41%) 14% <0%> (ø) ⬇️
...apua/job/engine/jbatch/JobEngineServiceJbatch.java 48.14% <0%> (+8.33%) 7% <0%> (+1%) ⬆️
...ransport/mqtt/pooling/PooledMqttClientFactory.java 90% <0%> (+10%) 6% <0%> (ø) ⬇️
...ne/queue/jbatch/QueuedJobExecutionFactoryImpl.java 37.5% <0%> (+12.5%) 3% <0%> (+1%) ⬆️
...e/kapua/job/engine/jbatch/driver/JbatchDriver.java 68.9% <0%> (+12.6%) 20% <0%> (+6%) ⬆️
...a/job/engine/jbatch/listener/KapuaJobListener.java 90.27% <0%> (+15.97%) 28% <0%> (+7%) ⬆️
...ne/queue/jbatch/QueuedJobExecutionServiceImpl.java 50% <0%> (+25%) 8% <0%> (+4%) ⬆️
...ipse/kapua/transport/mqtt/MqttClientException.java 28.57% <0%> (+28.57%) 1% <0%> (+1%) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92756e4...c40414c. Read the comment docs.

@Coduz Coduz marked this pull request as ready for review November 21, 2019 10:46
Signed-off-by: coduz <alberto.codutti@eurotech.com>
@Coduz Coduz force-pushed the fix-deviceManagementLifecycleService branch from ab2fa81 to c40414c Compare November 21, 2019 13:48
@Coduz
Copy link
Contributor Author

Coduz commented Nov 21, 2019

Build before rebase on latest develop passed: https://travis-ci.org/eclipse/kapua/builds/614985053

@Coduz Coduz merged commit 0eee9bd into eclipse-kapua:develop Nov 21, 2019
@Coduz Coduz deleted the fix-deviceManagementLifecycleService branch November 21, 2019 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug This is a bug or an unexpected behaviour. Fix it!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant