Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenAPI definition files #2784

Closed
wants to merge 6 commits into from

Conversation

gbarbon
Copy link
Contributor

@gbarbon gbarbon commented Nov 28, 2019

This PR add the OpenAPI definition files to Kapua.

Related Issue
n/a

Description of the solution adopted
OpenAPI specification have been added for Kapua Services. Moreover, Swagger annotations have also been removed.

Screenshots
n/a

Any side note on the changes made
n/a

@codecov
Copy link

codecov bot commented Nov 28, 2019

Codecov Report

Merging #2784 into develop will increase coverage by 16.43%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##             develop    #2784       +/-   ##
==============================================
+ Coverage      41.05%   57.49%   +16.43%     
- Complexity      2591     3166      +575     
==============================================
  Files           1074     1074               
  Lines          30474    30474               
  Branches        2427     2427               
==============================================
+ Hits           12512    17520     +5008     
+ Misses         17005    11794     -5211     
- Partials         957     1160      +203
Impacted Files Coverage Δ Complexity Δ
.../notification/ManagementOperationNotification.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...kapua/service/authorization/access/AccessRole.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...pua/service/authorization/role/RolePermission.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...pua/service/device/registry/event/DeviceEvent.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...apua/service/certificate/info/CertificateInfo.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...n/java/org/eclipse/kapua/message/KapuaPayload.java 100% <ø> (ø) 0 <0> (ø) ⬇️
.../eclipse/kapua/service/device/registry/Device.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...apua/service/authentication/token/AccessToken.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...kapua/service/authorization/access/AccessInfo.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...e/device/registry/connection/DeviceConnection.java 0% <ø> (ø) 0 <0> (ø) ⬇️
... and 249 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb446c9...5b36aa5. Read the comment docs.

@gbarbon gbarbon marked this pull request as ready for review December 2, 2019 16:06
@lorthirk lorthirk force-pushed the feature-openApiFiles branch 3 times, most recently from f4c36ea to 8802dc7 Compare December 5, 2019 10:44
Claudio Mezzasalma and others added 6 commits December 5, 2019 11:44
Signed-off-by: Claudio Mezzasalma <claudio.mezzasalma@eurotech.com>
Signed-off-by: Claudio Mezzasalma <claudio.mezzasalma@eurotech.com>
Signed-off-by: Claudio Mezzasalma <claudio.mezzasalma@eurotech.com>
Signed-off-by: Gianluca Barbon <gianluca.barbon@eurotech.com>
Signed-off-by: Gianluca Barbon <gianluca.barbon@eurotech.com>
Signed-off-by: Gianluca Barbon <gianluca.barbon@eurotech.com>
@lorthirk lorthirk force-pushed the feature-openApiFiles branch from 8802dc7 to 5b36aa5 Compare December 5, 2019 10:44
@lorthirk lorthirk added the CQ pending This PR needs a CQ to be approved from Eclipse before merging. label Dec 5, 2019
@lorthirk
Copy link

lorthirk commented Dec 5, 2019

Do we need to ask a CQ even if @gbarbon work is well below a thousand lines?

@lorthirk
Copy link

Closing this PR as #2795 has been created with more OpenAPI files

@lorthirk lorthirk closed this Dec 12, 2019
@gbarbon gbarbon deleted the feature-openApiFiles branch November 4, 2020 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CQ pending This PR needs a CQ to be approved from Eclipse before merging.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants