Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chng general improvements #2788

Merged
merged 2 commits into from
Dec 6, 2019

Conversation

Coduz
Copy link
Contributor

@Coduz Coduz commented Dec 5, 2019

This PR fixes some problems while reviewing the code of Kapua

Related Issue
None

Description of the solution adopted
Improved the Device Management Operation log generation from the Device Management Notifications that comes from the device during the Deploy-V2. Now subsequent COMPLETED event will append to the existing log.

Fixed a mapping error for which resources on the NOTIFY topic were not mapped and lost during the DeviceManagementNotification processing.

Screenshots
None

Any side note on the changes made
None

Coduz added 2 commits December 5, 2019 15:38
Signed-off-by: coduz <alberto.codutti@eurotech.com>
Signed-off-by: coduz <alberto.codutti@eurotech.com>
@Coduz Coduz added the Bug This is a bug or an unexpected behaviour. Fix it! label Dec 5, 2019
@Coduz Coduz requested a review from lorthirk December 5, 2019 15:06
@codecov
Copy link

codecov bot commented Dec 6, 2019

Codecov Report

Merging #2788 into develop will increase coverage by 16.42%.
The diff coverage is 50%.

Impacted file tree graph

@@              Coverage Diff               @@
##             develop    #2788       +/-   ##
==============================================
+ Coverage      41.05%   57.48%   +16.42%     
- Complexity      2591     3153      +562     
==============================================
  Files           1074     1074               
  Lines          30474    30500       +26     
  Branches        2427     2435        +8     
==============================================
+ Hits           12512    17533     +5021     
+ Misses         17005    11796     -5209     
- Partials         957     1171      +214
Impacted Files Coverage Δ Complexity Δ
...ator/kura/kapua/TranslatorLifeNotifyKuraKapua.java 89.09% <100%> (+0.2%) 9 <0> (ø) ⬇️
...ssage/kura/app/notification/KuraNotifyMetrics.java 100% <100%> (ø) 3 <0> (ø) ⬇️
...ssage/kura/app/notification/KuraNotifyChannel.java 66.66% <100%> (+11.11%) 3 <2> (+2) ⬆️
...ssage/kura/app/notification/KuraNotifyPayload.java 60.86% <18.18%> (+2.53%) 12 <1> (+3) ⬆️
.../DeviceManagementNotificationMessageProcessor.java 71.42% <33.33%> (+3.13%) 0 <0> (ø) ⬇️
...anager/DeviceManagementRegistryManagerService.java 73.07% <40%> (-1.25%) 0 <0> (ø)
...s/message/notification/KapuaNotifyChannelImpl.java 75% <66.66%> (-25%) 0 <0> (ø)
.../kapua/service/datastore/steps/DatastoreSteps.java 88.57% <0%> (+0.15%) 53% <0%> (-191%) ⬇️
...service/datastore/internal/MessageStoreFacade.java 49.1% <0%> (+0.44%) 12% <0%> (-4%) ⬇️
...a/job/engine/jbatch/listener/KapuaJobListener.java 86.8% <0%> (+0.69%) 27% <0%> (ø) ⬇️
... and 246 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb446c9...a8433a3. Read the comment docs.

@Coduz Coduz merged commit 68fe2d7 into eclipse-kapua:develop Dec 6, 2019
@Coduz Coduz deleted the chng-generalImprovements branch December 6, 2019 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug This is a bug or an unexpected behaviour. Fix it!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants