Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JobStepRegistry readonly REST API #2790

Merged

Conversation

lorthirk
Copy link

@lorthirk lorthirk commented Dec 6, 2019

After merging #2789 we had no way to retrieve Job Steps for a given Job. This PR introduces a few endpoints:

  • GET {scopeId}/jobs/{jobId}/steps
  • GET {scopeId}/jobs/{jobId}/steps/{stepId}
  • POST {scopeId}/jobs/{jobId}/steps/_count
  • POST {scopeId}/jobs/{jobId}/steps/_query

Related Issue
To be merged after #2789

Signed-off-by: Claudio Mezzasalma <claudio.mezzasalma@eurotech.com>
@lorthirk lorthirk added Enhancement This PR/Issue improves an part of Kapua REST API We hope to REST everyday labels Dec 6, 2019
@lorthirk lorthirk requested a review from Coduz December 6, 2019 16:14
@codecov
Copy link

codecov bot commented Dec 6, 2019

Codecov Report

Merging #2790 into develop will increase coverage by 1.07%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             develop   #2790      +/-   ##
============================================
+ Coverage      56.42%   57.5%   +1.07%     
- Complexity      3073    3396     +323     
============================================
  Files           1074    1074              
  Lines          30500   30500              
  Branches        2435    2435              
============================================
+ Hits           17211   17538     +327     
+ Misses         12153   11791     -362     
- Partials        1136    1171      +35
Impacted Files Coverage Δ Complexity Δ
...lugin/authentication/AdminAuthenticationLogic.java 69.23% <0%> (-7.7%) 0% <0%> (ø)
...egistry/event/internal/DeviceEventServiceImpl.java 76.78% <0%> (-5.36%) 13% <0%> (-2%)
...e/kapua/job/engine/jbatch/driver/JbatchDriver.java 69.74% <0%> (+0.84%) 21% <0%> (+1%) ⬆️
.../eclipse/kapua/qa/common/SimulatedDeviceSteps.java 94.24% <0%> (+1.04%) 60% <0%> (ø) ⬇️
.../broker/core/plugin/KapuaSecurityBrokerFilter.java 75.23% <0%> (+1.23%) 0% <0%> (ø) ⬇️
...e/kapua/broker/core/plugin/metric/LoginMetric.java 86.66% <0%> (+2.22%) 0% <0%> (ø) ⬇️
.../org/eclipse/kapua/qa/common/cucumber/CucUser.java 42.85% <0%> (+2.38%) 12% <0%> (+1%) ⬆️
...n/java/org/eclipse/kapua/qa/common/BasicSteps.java 57.5% <0%> (+2.5%) 19% <0%> (+4%) ⬆️
...lipse/kapua/kura/simulator/MqttAsyncTransport.java 55.55% <0%> (+2.77%) 0% <0%> (ø) ⬇️
...n/java/org/eclipse/kapua/qa/common/Suppressed.java 51.72% <0%> (+3.44%) 12% <0%> (+1%) ⬆️
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1fec25c...5264b09. Read the comment docs.

@Coduz Coduz merged commit 058bab0 into eclipse-kapua:develop Dec 9, 2019
@lorthirk lorthirk deleted the feature-targetCsvAndJobRestApi branch January 24, 2020 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement This PR/Issue improves an part of Kapua REST API We hope to REST everyday
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants