Role unit tests

[code-incubus]

Signed-off-by: code-incubus nemanja.milutinovic@comtrade.com

Added unit test scenarios for Role Service.

Related Issue
None

Description of the solution adopted
Test scenarios that are added in this PR are checking functionalities regarding Roles. All scenarios are added to RoleServiceUnitTests.feature. Scenarios are testing if Roles are correctly created, edited or deleted.

Screenshots
/

Any side note on the changes made
/

[codecov]

Codecov Report

Merging #2843 into develop will decrease coverage by 3.68%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             develop    #2843      +/-   ##
=============================================
- Coverage       54.1%   50.42%   -3.69%     
+ Complexity      2261     2130     -131     
=============================================
  Files           1008     1008              
  Lines          21777    21777              
  Branches        1973     1973              
=============================================
- Hits           11783    10981     -802     
- Misses          9095     9938     +843     
+ Partials         899      858      -41

Impacted Files	Coverage Δ	Complexity Δ
...r/core/plugin/KapuaDuplicateClientIdException.java	0% <0%> (-100%)	0% <0%> (ø)
.../kapua/service/tag/internal/TagListResultImpl.java	0% <0%> (-100%)	0% <0%> (-1%)
.../endpoint/internal/EndpointInfoListResultImpl.java	0% <0%> (-100%)	0% <0%> (-1%)
...apua/broker/core/plugin/KapuaBrokerErrorCodes.java	0% <0%> (-100%)	0% <0%> (ø)
...lipse/kapua/service/tag/internal/TagQueryImpl.java	0% <0%> (-100%)	0% <0%> (-1%)
...ervice/account/internal/AccountListResultImpl.java	0% <0%> (-100%)	0% <0%> (ø)
...rvice/endpoint/internal/EndpointInfoQueryImpl.java	0% <0%> (-100%)	0% <0%> (-1%)
...rvice/account/internal/KapuaAccountErrorCodes.java	0% <0%> (-100%)	0% <0%> (ø)
...lator/app/deploy/DeploymentPackageInformation.java	0% <0%> (-93.75%)	0% <0%> (ø)
...org/eclipse/kapua/service/tag/internal/TagDAO.java	0% <0%> (-91.67%)	0% <0%> (-6%)
... and 121 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 959bee4...f77c7dd. Read the comment docs.

[LeoNerdoG]

Hej @code-incubus,
I have reviewed this PR and there are some changes to be made.
Plase fix this as soon as you can.
@Coduz after the changes are made and all the tests pass and codeCove is OK, please merge this.

[code-incubus]

Done. @LeoNerdoG

[Coduz]

Small thing.

Could you please remove () when declaring the @Inject annotation?
Also, since the init of the RoleServiceImpl has changes, can you please check that the runtime is not affected by that? If you didn't do it already. Running a console and CRUDing a Role should be enough.

Thanks,

• Alberto

[code-incubus]

Hi @Coduz, @LeoNerdoG
Checked. Everything works fine and all the changes are made.

[LeoNerdoG]

Hey @Coduz,
I have checked this PR and from QA stanpoint everything is OK.
All the tests have passed, code coverage has increased, no CQ is needed, so I guess we can merge this.

Leo