Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Unit Tests For Job Service #2862

Merged
merged 1 commit into from
Feb 26, 2020
Merged

Added Unit Tests For Job Service #2862

merged 1 commit into from
Feb 26, 2020

Conversation

code-incubus
Copy link
Contributor

Signed-off-by: code-incubus nemanja.milutinovic@comtrade.com

Added unit test scenarios for Job Service.

Related Issue
None

Test scenarios that are added in this PR are checking functionalities regarding Jobs. All scenarios are added to JobService.feature. Scenarios are testing if Jobs are correctly created and edited.

Screenshots
/

Any side note on the changes made
/

@codecov
Copy link

codecov bot commented Feb 24, 2020

Codecov Report

Merging #2862 into develop will increase coverage by 23.01%.
The diff coverage is 83.33%.

Impacted file tree graph

@@              Coverage Diff               @@
##             develop    #2862       +/-   ##
==============================================
+ Coverage      32.26%   55.28%   +23.01%     
- Complexity      1462     2359      +897     
==============================================
  Files           1009     1009               
  Lines          21800    21798        -2     
  Branches        1976     1976               
==============================================
+ Hits            7034    12050     +5016     
+ Misses         14224     8840     -5384     
- Partials         542      908      +366
Impacted Files Coverage Δ Complexity Δ
...pse/kapua/service/job/internal/JobServiceImpl.java 79.16% <83.33%> (+44.03%) 20 <0> (+10) ⬆️
...ce/datastore/client/rest/EsRestClientProvider.java 25.53% <0%> (+0.7%) 13% <0%> (+1%) ⬆️
...re/plugin/authentication/DefaultAuthenticator.java 88.23% <0%> (+1.96%) 0% <0%> (ø) ⬇️
.../service/device/call/message/kura/KuraPayload.java 53.64% <0%> (+1.98%) 29% <0%> (+1%) ⬆️
...a/org/eclipse/kapua/commons/jpa/EntityManager.java 66.66% <0%> (+2.08%) 0% <0%> (ø) ⬇️
...ua/broker/core/listener/DeviceMessageListener.java 55.31% <0%> (+2.12%) 0% <0%> (ø) ⬇️
.../kapua/commons/model/query/AbstractKapuaQuery.java 73.33% <0%> (+2.22%) 0% <0%> (ø) ⬇️
...a/org/eclipse/kapua/locator/guice/KapuaModule.java 83.52% <0%> (+2.35%) 0% <0%> (ø) ⬇️
...e/kapua/broker/core/plugin/KapuaPrincipalImpl.java 47.36% <0%> (+2.63%) 0% <0%> (ø) ⬇️
...ua/service/device/registry/internal/DeviceDAO.java 89.65% <0%> (+3.44%) 10% <0%> (+1%) ⬆️
... and 309 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d44848...f5cd635. Read the comment docs.

@LeoNerdoG
Copy link
Contributor

Hi @code-incubus,
I have checked this PR and it looks OK. There is only one thing - please rebase it to the latest develop, because you are missing quite a lot commits.
After that It will be approved and merged (I can see that there was no problem with the tests).

Signed-off-by: code-incubus <nemanja.milutinovic@comtrade.com>
@code-incubus
Copy link
Contributor Author

@LeoNerdoG Done.

@LeoNerdoG
Copy link
Contributor

Hi @code-incubus,
I have checked this and now everything is OK.
@Coduz, can you please merge this after the tests complete?

@Coduz Coduz merged commit f57b71f into eclipse-kapua:develop Feb 26, 2020
@Coduz Coduz added the Test Test related stuff. It's a dirty job, but someone needs to do that! label Feb 26, 2020
@code-incubus code-incubus deleted the JobServiceUnitTests branch February 26, 2020 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Test Test related stuff. It's a dirty job, but someone needs to do that!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants