Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Unit Tests For User Service #2863

Merged
merged 1 commit into from
Feb 27, 2020
Merged

Added Unit Tests For User Service #2863

merged 1 commit into from
Feb 27, 2020

Conversation

code-incubus
Copy link
Contributor

Signed-off-by: code-incubus nemanja.milutinovic@comtrade.com

Added several unit test scenarios for User Service.

Related Issue
None

Description of the solution adopted
Test scenarios that are added in this PR are checking functionalities regarding Users. All scenarios are added to UserService.feature. Scenarios are testing if Users are correctly filtered or not.

Screenshots
/

Any side note on the changes made
/

Copy link
Contributor

@LeoNerdoG LeoNerdoG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Coduz,
I have checked this PR and it looks good. You can merge it when the tests complete.

@codecov
Copy link

codecov bot commented Feb 26, 2020

Codecov Report

Merging #2863 into develop will increase coverage by 0.53%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #2863      +/-   ##
=============================================
+ Coverage      54.65%   55.18%   +0.53%     
- Complexity      2299     2358      +59     
=============================================
  Files           1009     1009              
  Lines          21798    21798              
  Branches        1976     1976              
=============================================
+ Hits           11913    12029     +116     
+ Misses          8976     8861     -115     
+ Partials         909      908       -1
Impacted Files Coverage Δ Complexity Δ
...pse/kapua/transport/mqtt/MqttClientErrorCodes.java 0% <0%> (-100%) 0% <0%> (-1%)
...ipse/kapua/transport/mqtt/MqttClientException.java 0% <0%> (-28.58%) 0% <0%> (-1%)
...pse/kapua/broker/core/pool/JmsConsumerWrapper.java 60% <0%> (-15%) 0% <0%> (ø)
...ransport/mqtt/pooling/PooledMqttClientFactory.java 76.66% <0%> (-10%) 6% <0%> (ø)
...a/org/eclipse/kapua/transport/mqtt/MqttClient.java 56.41% <0%> (-6.42%) 13% <0%> (ø)
.../broker/core/plugin/KapuaSecurityBrokerFilter.java 75.23% <0%> (-0.93%) 0% <0%> (ø)
...pse/kapua/commons/service/internal/ServiceDAO.java 77.16% <0%> (+1.73%) 0% <0%> (ø) ⬇️
...apua/job/engine/jbatch/JobEngineServiceJbatch.java 51.85% <0%> (+1.85%) 8% <0%> (ø) ⬇️
...onfiguration/AbstractKapuaConfigurableService.java 80% <0%> (+3.63%) 0% <0%> (ø) ⬇️
...e/kapua/service/job/step/internal/JobStepImpl.java 70.37% <0%> (+3.7%) 11% <0%> (+1%) ⬆️
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f57b71f...2a7b981. Read the comment docs.

Signed-off-by: code-incubus <nemanja.milutinovic@comtrade.com>
@Coduz Coduz added the Test Test related stuff. It's a dirty job, but someone needs to do that! label Feb 27, 2020
@Coduz Coduz merged commit b65afa1 into eclipse-kapua:develop Feb 27, 2020
@code-incubus code-incubus deleted the UserServiceUnitTestsV2 branch February 27, 2020 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Test Test related stuff. It's a dirty job, but someone needs to do that!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants