Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transport module improvements #2883

Merged
merged 6 commits into from
Mar 10, 2020

Conversation

Coduz
Copy link
Contributor

@Coduz Coduz commented Mar 9, 2020

This PR improves all kapua-transport modules.

Related Issue
None

Description of the solution adopted

  • Exceptions have been refactored and moved to kapua-transport-api module to make them catchable from invoking code (replaces the general usage of carch (KapuaException e) {. Also exception messages have been added to prime a user-friendly message.
  • Implementation of the translators have been improved and code has gone trough a cleanup, where possibile.
  • TransportFacade now implements AutoClosable

Screenshots
None

Any side note on the changes made
Created a utility to get a java.util.Random instance in a unified way.

Coduz added 6 commits March 9, 2020 14:30
Signed-off-by: coduz <alberto.codutti@eurotech.com>
Signed-off-by: coduz <alberto.codutti@eurotech.com>
Signed-off-by: coduz <alberto.codutti@eurotech.com>
…qtt implementation

Signed-off-by: coduz <alberto.codutti@eurotech.com>
Signed-off-by: coduz <alberto.codutti@eurotech.com>
Signed-off-by: coduz <alberto.codutti@eurotech.com>
@Coduz Coduz added the Enhancement This PR/Issue improves an part of Kapua label Mar 9, 2020
@Coduz Coduz requested a review from lorthirk March 9, 2020 14:03
@codecov
Copy link

codecov bot commented Mar 9, 2020

Codecov Report

Merging #2883 into develop will decrease coverage by 0.09%.
The diff coverage is 45.24%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #2883      +/-   ##
=============================================
- Coverage      55.24%   55.15%   -0.10%     
- Complexity      2363     2368       +5     
=============================================
  Files           1009     1021      +12     
  Lines          21779    21869      +90     
  Branches        1976     1977       +1     
=============================================
+ Hits           12031    12061      +30     
- Misses          8843     8888      +45     
- Partials         905      920      +15     
Impacted Files Coverage Δ Complexity Δ
...service/device/management/message/KapuaMethod.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...t/commons/AbstractDeviceManagementServiceImpl.java 87.71% <ø> (ø) 0.00 <0.00> (ø)
...anslator/kura/kapua/MethodDictionaryKuraKapua.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...ansport/exception/TransportClientGetException.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
.../kapua/transport/jms/setting/JmsClientSetting.java 100.00% <ø> (ø) 3.00 <0.00> (ø)
...ua/transport/jms/setting/JmsClientSettingKeys.java 100.00% <ø> (ø) 3.00 <0.00> (ø)
...clipse/kapua/transport/message/jms/JmsMessage.java 50.00% <0.00%> (-7.15%) 4.00 <1.00> (ø)
...clipse/kapua/transport/message/jms/JmsPayload.java 66.66% <ø> (ø) 2.00 <0.00> (ø)
...ipse/kapua/transport/message/mqtt/MqttMessage.java 52.17% <0.00%> (-4.97%) 7.00 <1.00> (ø)
...ipse/kapua/transport/message/mqtt/MqttPayload.java 66.66% <ø> (ø) 2.00 <0.00> (ø)
... and 65 more

@Coduz Coduz merged commit c16d392 into eclipse-kapua:develop Mar 10, 2020
@Coduz Coduz deleted the feature-transportImprovements branch March 10, 2020 10:59
@Coduz Coduz mentioned this pull request Mar 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement This PR/Issue improves an part of Kapua
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants