Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DeviceManagementOperationService.findByOperationId feature #2885

Merged

Conversation

Coduz
Copy link
Contributor

@Coduz Coduz commented Mar 9, 2020

This PR adds findByOperationId method to DeviceManagementOperationService to allow retrieval of a DeviceManagementOperation by its DeviceManagementOperation.operationId.

Related Issue
None

Description of the solution adopted
Added method to API and implementation.

Screenshots
None

Any side note on the changes made
None

Signed-off-by: coduz <alberto.codutti@eurotech.com>
@Coduz Coduz added the Enhancement This PR/Issue improves an part of Kapua label Mar 9, 2020
@Coduz Coduz requested a review from lorthirk March 9, 2020 14:49
@codecov
Copy link

codecov bot commented Mar 9, 2020

Codecov Report

Merging #2885 into develop will decrease coverage by 0.10%.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #2885      +/-   ##
=============================================
- Coverage      55.24%   55.13%   -0.11%     
+ Complexity      2363     2360       -3     
=============================================
  Files           1009     1009              
  Lines          21779    21786       +7     
  Branches        1976     1976              
=============================================
- Hits           12031    12011      -20     
- Misses          8843     8868      +25     
- Partials         905      907       +2     
Impacted Files Coverage Δ Complexity Δ
...t/commons/AbstractDeviceManagementServiceImpl.java 86.53% <100.00%> (-1.19%) 0.00 <0.00> (ø)
...obDeviceManagementOperationManagerServiceImpl.java 76.62% <100.00%> (-8.38%) 13.00 <1.00> (-2.00)
...anager/DeviceManagementRegistryManagerService.java 72.00% <100.00%> (-1.08%) 0.00 <0.00> (ø)
.../DeviceManagementOperationRegistryServiceImpl.java 69.64% <100.00%> (+1.64%) 14.00 <2.00> (+2.00)
...ce/registry/connection/DeviceConnectionStatus.java 71.42% <0.00%> (-28.58%) 0.00% <0.00%> (ø%)
...pse/kapua/broker/core/pool/JmsProducerWrapper.java 50.00% <0.00%> (-15.00%) 0.00% <0.00%> (ø%)
...internal/DeviceManagementOperationFactoryImpl.java 33.33% <0.00%> (-11.12%) 3.00% <0.00%> (-1.00%)
.../DeviceManagementNotificationMessageProcessor.java 64.28% <0.00%> (-7.15%) 0.00% <0.00%> (ø%)
...ice/job/targets/internal/JobTargetServiceImpl.java 72.72% <0.00%> (-6.07%) 12.00% <0.00%> (-1.00%)
... and 6 more

@Coduz Coduz merged commit 06a4a19 into eclipse-kapua:develop Mar 10, 2020
@Coduz Coduz deleted the feature-deviceManagementByOperationId branch March 10, 2020 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement This PR/Issue improves an part of Kapua
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants