Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NPM scope to swagger-cli #2893

Merged

Conversation

lorthirk
Copy link

To generate OpenAPI specification files we leverage swagger-cli. With the latest release, 4.0.1, the package has been put under the @apidevtools NPM scope; the old package, swagger-cli, should act as a wrapper on the new package naming, except it's not. So to avoid any issue, it's better to depend on the new package avoiding to rely on the unscoped one.

Related Issue
No related issue

Signed-off-by: Claudio Mezzasalma <claudio.mezzasalma@eurotech.com>
@lorthirk lorthirk added Bug This is a bug or an unexpected behaviour. Fix it! Dependencies PR that updates dependencies. Be on the edge! labels Mar 16, 2020
@lorthirk lorthirk requested a review from Coduz March 16, 2020 09:06
@codecov
Copy link

codecov bot commented Mar 16, 2020

Codecov Report

Merging #2893 into develop will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #2893      +/-   ##
=============================================
- Coverage      55.36%   55.35%   -0.01%     
- Complexity      2374     2376       +2     
=============================================
  Files           1024     1024              
  Lines          21953    21953              
  Branches        1994     1994              
=============================================
- Hits           12155    12153       -2     
- Misses          8883     8887       +4     
+ Partials         915      913       -2
Impacted Files Coverage Δ Complexity Δ
...xception/ManagementOperationManagerErrorCodes.java 0% <0%> (-100%) 0% <0%> (ø)
...ementOperationNotificationProcessingException.java 0% <0%> (-77.28%) 0% <0%> (ø)
.../engine/jbatch/exception/JobResumingException.java 0% <0%> (-50%) 0% <0%> (-1%)
...ob/engine/jbatch/exception/JobEngineException.java 33.33% <0%> (-33.34%) 1% <0%> (-1%)
...rtz/persistence/KapuaQuartzConnectionProvider.java 87.5% <0%> (-12.5%) 4% <0%> (-1%)
.../DeviceManagementNotificationMessageProcessor.java 64.28% <0%> (-7.15%) 0% <0%> (ø)
...ce/management/commons/call/DeviceCallExecutor.java 62.79% <0%> (-4.66%) 0% <0%> (ø)
...anager/DeviceManagementRegistryManagerService.java 72% <0%> (-2.67%) 0% <0%> (ø)
...apua/job/engine/jbatch/JobEngineServiceJbatch.java 50% <0%> (ø) 8% <0%> (+1%) ⬆️
...nnection/internal/DeviceConnectionServiceImpl.java 68.67% <0%> (+2.4%) 15% <0%> (+1%) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f198f3...e3b9b2c. Read the comment docs.

@lorthirk lorthirk merged commit ab7e214 into eclipse-kapua:develop Mar 16, 2020
@lorthirk lorthirk deleted the fix-scopedSwaggerCliPackage branch March 16, 2020 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug This is a bug or an unexpected behaviour. Fix it! Dependencies PR that updates dependencies. Be on the edge!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants