Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed exception messages missing the positional argument number #2900

Merged
merged 1 commit into from
Mar 18, 2020

Conversation

Coduz
Copy link
Contributor

@Coduz Coduz commented Mar 18, 2020

This PR fixes exception messages that were mistakenly missing the positional argument numbers, which is required by MessageFormat while SLF4J Logger messages requires only {}

Related Issue
None

Description of the solution adopted
Added positional argument numbers.

Screenshots
None

Any side note on the changes made
None

Signed-off-by: coduz <alberto.codutti@eurotech.com>
@Coduz Coduz added the Bug This is a bug or an unexpected behaviour. Fix it! label Mar 18, 2020
@Coduz Coduz requested a review from lorthirk March 18, 2020 14:02
@codecov
Copy link

codecov bot commented Mar 18, 2020

Codecov Report

Merging #2900 into develop will increase coverage by 0.15%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #2900      +/-   ##
=============================================
+ Coverage      55.26%   55.41%   +0.15%     
- Complexity      2370     2381      +11     
=============================================
  Files           1024     1024              
  Lines          21961    21961              
  Branches        2000     2000              
=============================================
+ Hits           12136    12169      +33     
+ Misses          8906     8880      -26     
+ Partials         919      912       -7     
Impacted Files Coverage Δ Complexity Δ
...rtz/persistence/KapuaQuartzConnectionProvider.java 87.50% <0.00%> (-12.50%) 4.00% <0.00%> (-1.00%)
...plugin/authentication/UserAuthenticationLogic.java 76.57% <0.00%> (+1.80%) 0.00% <0.00%> (ø%)
...apua/job/engine/jbatch/JobEngineServiceJbatch.java 50.00% <0.00%> (+1.85%) 7.00% <0.00%> (ø%)
...ua/broker/core/listener/DeviceMessageListener.java 57.44% <0.00%> (+2.12%) 0.00% <0.00%> (ø%)
...nnection/internal/DeviceConnectionServiceImpl.java 68.67% <0.00%> (+2.40%) 15.00% <0.00%> (+1.00%)
...ator/kura/kapua/TranslatorLifeNotifyKuraKapua.java 92.72% <0.00%> (+3.63%) 10.00% <0.00%> (+1.00%)
...ce/management/commons/call/DeviceCallExecutor.java 67.44% <0.00%> (+4.65%) 0.00% <0.00%> (ø%)
...ice/job/targets/internal/JobTargetServiceImpl.java 78.78% <0.00%> (+6.06%) 13.00% <0.00%> (+1.00%)
...e/jbatch/listener/QueuedJobExecutionCheckTask.java 93.54% <0.00%> (+6.45%) 7.00% <0.00%> (ø%)
.../DeviceManagementNotificationMessageProcessor.java 71.42% <0.00%> (+7.14%) 0.00% <0.00%> (ø%)
... and 4 more

@Coduz Coduz merged commit 9685d9e into eclipse-kapua:develop Mar 18, 2020
@Coduz Coduz deleted the fix-exceptionMessagesFormat branch March 18, 2020 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug This is a bug or an unexpected behaviour. Fix it!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants