Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature DeviceCall module improvements #2901

Merged
merged 6 commits into from
Mar 19, 2020

Conversation

Coduz
Copy link
Contributor

@Coduz Coduz commented Mar 18, 2020

This PR improves the kapua-device-call module and submodule implementation and documentation.

Related Issue
None

Description of the solution adopted
Added a bunch of javadoc and fixed some bug and class layout error that were found while adding javadoc to classes.

Screenshots
None

Any side note on the changes made
None

@Coduz Coduz added Bug This is a bug or an unexpected behaviour. Fix it! Enhancement This PR/Issue improves an part of Kapua labels Mar 18, 2020
@Coduz Coduz requested a review from lorthirk March 18, 2020 14:48
@codecov
Copy link

codecov bot commented Mar 18, 2020

Codecov Report

Merging #2901 into develop will increase coverage by 0.14%.
The diff coverage is 60.15%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #2901      +/-   ##
=============================================
+ Coverage      55.36%   55.50%   +0.14%     
- Complexity      2374     2379       +5     
=============================================
  Files           1024     1024              
  Lines          21953    21982      +29     
  Branches        1994     2014      +20     
=============================================
+ Hits           12155    12202      +47     
+ Misses          8883     8863      -20     
- Partials         915      917       +2     
Impacted Files Coverage Δ Complexity Δ
...ce/device/call/exception/DeviceCallErrorCodes.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...ice/device/call/exception/DeviceCallException.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...device/call/exception/DeviceCallSendException.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...ice/call/exception/DeviceCallTimeoutException.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...pua/service/device/call/message/DevicePayload.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...ce/device/call/kura/KuraDeviceCallFactoryImpl.java 100.00% <ø> (ø) 2.00 <0.00> (ø)
...a/service/device/call/kura/KuraDeviceCallback.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
.../device/call/kura/KuraDeviceResponseContainer.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...rvice/device/call/kura/KuraMessageFactoryImpl.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
.../call/kura/exception/KuraDeviceCallErrorCodes.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
... and 72 more

Coduz added 4 commits March 19, 2020 10:15
Signed-off-by: coduz <alberto.codutti@eurotech.com>
Signed-off-by: coduz <alberto.codutti@eurotech.com>
Signed-off-by: coduz <alberto.codutti@eurotech.com>
Signed-off-by: coduz <alberto.codutti@eurotech.com>
@Coduz Coduz force-pushed the feature-deviceCallImprovements branch from 948471c to 0925e51 Compare March 19, 2020 09:46
Coduz added 2 commits March 19, 2020 11:09
Signed-off-by: coduz <alberto.codutti@eurotech.com>
Signed-off-by: coduz <alberto.codutti@eurotech.com>
@Coduz Coduz force-pushed the feature-deviceCallImprovements branch from 0925e51 to 5c7857f Compare March 19, 2020 10:09
@Coduz Coduz merged commit 9676b31 into eclipse-kapua:develop Mar 19, 2020
@Coduz Coduz deleted the feature-deviceCallImprovements branch March 19, 2020 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug This is a bug or an unexpected behaviour. Fix it! Enhancement This PR/Issue improves an part of Kapua
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants