Added Unit tests for StringUtil class #2913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #2913 +/- ##
=============================================
+ Coverage 55.64% 56.19% +0.54%
- Complexity 2531 2535 +4
=============================================
Files 1040 1040
Lines 22568 22568
Branches 2036 2036
=============================================
+ Hits 12557 12681 +124
+ Misses 9067 8959 -108
+ Partials 944 928 -16
|
|
Hey @Coduz, Thanks! |
LeoNerdoG
force-pushed
the
commonsUnitTests
branch
2 times, most recently
from
9b60cda to
fccf965
Compare
I have added unit tests for StringUtil class whichc has not yet been covered with the tests, so the coverage of this file went from 0% to 85% (line coverage). I still have to add additional tests for "splitValues" method, which has not et been tested because I do not want to exceed 1k LOC. Signed-off-by: Leonardo Gaube <leonardo.gaube@comtrade.com>
LeoNerdoG
force-pushed
the
commonsUnitTests
branch
from
fccf965 to
1cb6a3c
Compare
Coduz
approved these changes
Mar 26, 2020
Coduz
added
the
Test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added unit tests for StringUtil class whichc has not yet been covered with the tests, so the coverage of this file
went from 0% to 85% (line coverage). I still have to add additional tests for "splitValues" method, which has not et been tested
because I do not want to exceed 1k LOC.
Signed-off-by: Leonardo Gaube leonardo.gaube@comtrade.com
Related Issue
This PR fixes/closes #2912
Description of the solution adopted
The tests are written in pure JUnit style, although we have some written in cucumber - if necessary I will rewrite them, but for the time being we are just trying to increase the code coverage and to find some hidden bugs if there are any.
Screenshots
/
Any side note on the changes made
/