Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature docker vagrant ssh options #2923

Merged
merged 4 commits into from
Apr 3, 2020

Conversation

Coduz
Copy link
Contributor

@Coduz Coduz commented Apr 1, 2020

This PR adds options to start subsequent actions after executing Vagrant start and Docker deploy

Related Issue
None

Description of the solution adopted
Added/Edited scripts which not optionally allows for:

  • Vagrant (dev-tools/vagrant)

    • Added ssh.sh as shortcut for vagrant ssh {machineName}
    • Added destroy.sh as shortcut for vagrant destroy -f {machineName}
    • ./start.sh develop --ssh which automatically invokes ssh.sh develop to jump into the newly started machine
  • Docker (deployment/docker)

    • Added docker-logs.sh as shortcut for docker compose -f {composeFile} logs -f
    • ./docker-deploy.sh --logs which automatically invokes docker-logs.sh to open container logs right after the deploy.

Powershell script have been updated too

Screenshots
None

Any side note on the changes made
Just some cleanups and improvements.
Power shell script now forcibly require PowerShell at least version 7. See https://docs.microsoft.com/en-us/powershell/module/microsoft.powershell.core/about/about_requires?view=powershell-7#-version-nn

@Coduz Coduz added the Enhancement This PR/Issue improves an part of Kapua label Apr 1, 2020
@Coduz Coduz requested a review from lorthirk April 1, 2020 07:33
@codecov
Copy link

codecov bot commented Apr 1, 2020

Codecov Report

Merging #2923 into develop will increase coverage by 1.17%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #2923      +/-   ##
=============================================
+ Coverage      54.84%   56.02%   +1.17%     
- Complexity      2432     2528      +96     
=============================================
  Files           1040     1040              
  Lines          22578    22578              
  Branches        2037     2037              
=============================================
+ Hits           12383    12649     +266     
+ Misses          9278     9007     -271     
- Partials         917      922       +5     
Impacted Files Coverage Δ Complexity Δ
...rtz/persistence/KapuaQuartzConnectionProvider.java 87.50% <0.00%> (-12.50%) 4.00% <0.00%> (-1.00%)
...ransport/mqtt/pooling/PooledMqttClientFactory.java 50.00% <0.00%> (-11.91%) 5.00% <0.00%> (-2.00%)
...a/org/eclipse/kapua/transport/mqtt/MqttClient.java 51.21% <0.00%> (-4.88%) 13.00% <0.00%> (-1.00%)
...nnection/internal/DeviceConnectionServiceImpl.java 66.26% <0.00%> (-2.41%) 14.00% <0.00%> (-1.00%)
...pse/kapua/commons/service/internal/ServiceDAO.java 77.24% <0.00%> (+0.34%) 0.00% <0.00%> (ø%)
...e/kapua/job/engine/jbatch/driver/JbatchDriver.java 67.71% <0.00%> (+0.78%) 21.00% <0.00%> (+1.00%)
...se/kapua/commons/configuration/ValueTokenizer.java 18.40% <0.00%> (+0.79%) 0.00% <0.00%> (ø%)
...service/datastore/internal/MessageStoreFacade.java 49.10% <0.00%> (+1.33%) 16.00% <0.00%> (+4.00%)
...datastore/internal/converter/ModelContextImpl.java 82.09% <0.00%> (+1.74%) 26.00% <0.00%> (+3.00%)
...apua/service/datastore/internal/schema/Schema.java 89.00% <0.00%> (+2.00%) 20.00% <0.00%> (+3.00%)
... and 24 more

@Coduz Coduz force-pushed the feature-dockerVagrantSshOptions branch 2 times, most recently from fa3f283 to dd21547 Compare April 2, 2020 08:59
Signed-off-by: coduz <alberto.codutti@eurotech.com>
@Coduz Coduz force-pushed the feature-dockerVagrantSshOptions branch from dd21547 to 02431e9 Compare April 2, 2020 10:34
Coduz added 3 commits April 2, 2020 12:39
Signed-off-by: coduz <alberto.codutti@eurotech.com>
Signed-off-by: coduz <alberto.codutti@eurotech.com>
Signed-off-by: coduz <alberto.codutti@eurotech.com>
@Coduz Coduz force-pushed the feature-dockerVagrantSshOptions branch from 02431e9 to 21b2c3c Compare April 2, 2020 10:39
@Coduz Coduz merged commit 77eccac into eclipse-kapua:develop Apr 3, 2020
@Coduz Coduz deleted the feature-dockerVagrantSshOptions branch April 3, 2020 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement This PR/Issue improves an part of Kapua
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants