Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove db password print while log level set to DEBUG #2925

Merged

Conversation

Coduz
Copy link
Contributor

@Coduz Coduz commented Apr 1, 2020

This PR removes the db password printout while log level is set to DEBUG.

Related Issue
None

Description of the solution adopted
Removed log line and improved logging in KapuaLiquibaseClient.

Output now looks like:

12:28:19.295 [main] INFO  o.e.k.c.l.KapuaLiquibaseClient - =================== KapuaLiquibaseClient configuration ===================
12:28:19.295 [main] INFO  o.e.k.c.l.KapuaLiquibaseClient - |	Liquibase Version: 3.0.5
12:28:19.295 [main] INFO  o.e.k.c.l.KapuaLiquibaseClient - |	DB connection info
12:28:19.295 [main] INFO  o.e.k.c.l.KapuaLiquibaseClient - |		JDBC URL: jdbc:h2:tcp://192.168.33.10:3306/kapuadb;schema=kapuadb
12:28:19.295 [main] INFO  o.e.k.c.l.KapuaLiquibaseClient - |		Username: kapua
12:28:19.295 [main] INFO  o.e.k.c.l.KapuaLiquibaseClient - |		Password: ******
12:28:19.295 [main] INFO  o.e.k.c.l.KapuaLiquibaseClient - |		Schema: kapuadb
12:28:19.295 [main] INFO  o.e.k.c.l.KapuaLiquibaseClient - |	Timestamp(3) fix (eclipse/kapua#2889)
12:28:19.295 [main] INFO  o.e.k.c.l.KapuaLiquibaseClient - |		Force timestamp fix: false
12:28:19.295 [main] INFO  o.e.k.c.l.KapuaLiquibaseClient - |		Apply timestamp fix: false
12:28:19.295 [main] INFO  o.e.k.c.l.KapuaLiquibaseClient - ========================================================================+=

Screenshots
None

Any side note on the changes made
Improved exception logging and handling in ContextListeners

Coduz added 2 commits April 1, 2020 12:58
Signed-off-by: coduz <alberto.codutti@eurotech.com>
Signed-off-by: coduz <alberto.codutti@eurotech.com>
@Coduz Coduz added the Bug This is a bug or an unexpected behaviour. Fix it! label Apr 1, 2020
@Coduz Coduz requested a review from lorthirk April 1, 2020 11:01
@codecov
Copy link

codecov bot commented Apr 1, 2020

Codecov Report

Merging #2925 into develop will increase coverage by 0.16%.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #2925      +/-   ##
=============================================
+ Coverage      56.01%   56.18%   +0.16%     
- Complexity      2528     2531       +3     
=============================================
  Files           1040     1040              
  Lines          22568    22578      +10     
  Branches        2036     2037       +1     
=============================================
+ Hits           12642    12685      +43     
+ Misses          8997     8962      -35     
- Partials         929      931       +2     
Impacted Files Coverage Δ Complexity Δ
.../kapua/commons/liquibase/KapuaLiquibaseClient.java 87.64% <100.00%> (+1.56%) 0.00 <0.00> (ø)
...ua/broker/core/listener/DeviceMessageListener.java 57.44% <0.00%> (-6.39%) 0.00% <0.00%> (ø%)
...ages/job/DevicePackageDownloadTargetProcessor.java 95.00% <0.00%> (-5.00%) 8.00% <0.00%> (-1.00%)
.../DeviceManagementOperationRegistryServiceImpl.java 66.07% <0.00%> (-3.58%) 12.00% <0.00%> (-2.00%)
...pse/kapua/commons/service/internal/ServiceDAO.java 76.89% <0.00%> (ø) 0.00% <0.00%> (ø%)
...apua/job/engine/jbatch/JobEngineServiceJbatch.java 50.00% <0.00%> (ø) 7.00% <0.00%> (-1.00%)
.../jbatch/persistence/JPAPersistenceManagerImpl.java 31.60% <0.00%> (+1.03%) 30.00% <0.00%> (ø%)
...nnection/internal/DeviceConnectionServiceImpl.java 68.67% <0.00%> (+2.40%) 15.00% <0.00%> (+1.00%)
...atch/persistence/jpa/JpaExecutionInstanceData.java 90.24% <0.00%> (+2.43%) 23.00% <0.00%> (+1.00%)
...obDeviceManagementOperationManagerServiceImpl.java 79.26% <0.00%> (+2.43%) 14.00% <0.00%> (ø%)
... and 8 more

@Coduz Coduz merged commit 08d965c into eclipse-kapua:develop Apr 2, 2020
@Coduz Coduz deleted the fix-dbPasswordLoggedWhileDebuggin branch April 2, 2020 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug This is a bug or an unexpected behaviour. Fix it!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants