Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed notification processing update retry strategy #2926

Merged

Conversation

Coduz
Copy link
Contributor

@Coduz Coduz commented Apr 1, 2020

This PR fixes the processing of a DeviceManagementNotification retry strategy.

Related Issue
None

Description of the solution adopted
Fixed the logic which looped indefinitely in case of first update failed.

Screenshots
None

Any side note on the changes made
None

Signed-off-by: coduz <alberto.codutti@eurotech.com>
@Coduz Coduz added the Bug This is a bug or an unexpected behaviour. Fix it! label Apr 1, 2020
@Coduz Coduz requested a review from lorthirk April 1, 2020 13:16
@codecov
Copy link

codecov bot commented Apr 1, 2020

Codecov Report

Merging #2926 into develop will increase coverage by 0.11%.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #2926      +/-   ##
=============================================
+ Coverage      56.01%   56.12%   +0.11%     
  Complexity      2528     2528              
=============================================
  Files           1040     1040              
  Lines          22568    22568              
  Branches        2036     2036              
=============================================
+ Hits           12642    12667      +25     
+ Misses          8997     8974      -23     
+ Partials         929      927       -2     
Impacted Files Coverage Δ Complexity Δ
...anager/DeviceManagementRegistryManagerService.java 72.00% <100.00%> (ø) 0.00 <0.00> (ø)
...ua/broker/core/listener/DeviceMessageListener.java 57.44% <0.00%> (-6.39%) 0.00% <0.00%> (ø%)
...obDeviceManagementOperationManagerServiceImpl.java 73.17% <0.00%> (-3.66%) 13.00% <0.00%> (-1.00%)
.../DeviceManagementOperationRegistryServiceImpl.java 66.07% <0.00%> (-3.58%) 12.00% <0.00%> (-2.00%)
...pse/kapua/commons/service/internal/ServiceDAO.java 77.24% <0.00%> (+0.34%) 0.00% <0.00%> (ø%)
...nnection/internal/DeviceConnectionServiceImpl.java 68.67% <0.00%> (+2.40%) 15.00% <0.00%> (+1.00%)
...ce/management/commons/call/DeviceCallExecutor.java 67.44% <0.00%> (+4.65%) 0.00% <0.00%> (ø%)
...a/org/eclipse/kapua/transport/mqtt/MqttClient.java 62.19% <0.00%> (+6.09%) 14.00% <0.00%> (ø%)
...lugin/authentication/AdminAuthenticationLogic.java 76.92% <0.00%> (+7.69%) 0.00% <0.00%> (ø%)
...ransport/mqtt/pooling/PooledMqttClientFactory.java 71.42% <0.00%> (+9.52%) 7.00% <0.00%> (ø%)
... and 3 more

@Coduz Coduz merged commit 2bd9558 into eclipse-kapua:develop Apr 2, 2020
@Coduz Coduz deleted the fix-deviceManagementNotificationRetry branch April 2, 2020 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug This is a bug or an unexpected behaviour. Fix it!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants