Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ServiceDAO findByField improvements #2930

Merged
merged 5 commits into from
Apr 17, 2020

Conversation

lorthirk
Copy link

@lorthirk lorthirk commented Apr 7, 2020

This PR extends ServiceDAO.findByField() to all fields, and also adds optional scopeId checking

Related Issue
No related issue

@lorthirk lorthirk requested a review from Coduz April 7, 2020 11:15
@lorthirk lorthirk added the Enhancement This PR/Issue improves an part of Kapua label Apr 7, 2020
@lorthirk lorthirk changed the title Change find by field improvements ServiceDAO findByField improvements Apr 7, 2020
@lorthirk lorthirk force-pushed the change-findByFieldImprovements branch from dc1a666 to 7cc720a Compare April 7, 2020 14:26
@lorthirk lorthirk force-pushed the change-findByFieldImprovements branch from 22eb86f to 933bcab Compare April 7, 2020 16:08
Signed-off-by: Claudio Mezzasalma <claudio.mezzasalma@eurotech.com>
@lorthirk lorthirk force-pushed the change-findByFieldImprovements branch 2 times, most recently from d7a516f to 32bad67 Compare April 8, 2020 15:55
@codecov
Copy link

codecov bot commented Apr 9, 2020

Codecov Report

Merging #2930 into develop will increase coverage by 1.66%.
The diff coverage is 52.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #2930      +/-   ##
=============================================
+ Coverage      54.30%   55.97%   +1.66%     
- Complexity      2381     2522     +141     
=============================================
  Files           1040     1040              
  Lines          22600    22621      +21     
  Branches        2039     2043       +4     
=============================================
+ Hits           12272    12661     +389     
+ Misses          9414     9025     -389     
- Partials         914      935      +21     
Impacted Files Coverage Δ Complexity Δ
.../kapua/commons/configuration/ServiceConfigDAO.java 23.07% <0.00%> (ø) 0.00 <0.00> (ø)
...ervice/job/execution/internal/JobExecutionDAO.java 81.25% <0.00%> (+18.75%) 6.00 <0.00> (+2.00)
...org/eclipse/kapua/service/job/internal/JobDAO.java 78.57% <0.00%> (ø) 6.00 <0.00> (ø)
...se/kapua/service/job/step/internal/JobStepDAO.java 83.33% <0.00%> (+27.77%) 6.00 <0.00> (+3.00)
...pua/service/job/targets/internal/JobTargetDAO.java 68.75% <0.00%> (ø) 5.00 <0.00> (ø)
...pse/kapua/commons/service/internal/ServiceDAO.java 75.00% <39.13%> (-0.52%) 0.00 <0.00> (ø)
.../JobDeviceManagementTriggerManagerServiceImpl.java 89.28% <50.00%> (-0.88%) 10.00 <1.00> (ø)
...g/eclipse/kapua/service/user/internal/UserDAO.java 84.21% <50.00%> (ø) 6.00 <1.00> (ø)
...e/scheduler/trigger/quartz/TriggerServiceImpl.java 71.77% <66.66%> (-0.45%) 32.00 <1.00> (-1.00)
...inition/internal/JobStepDefinitionServiceImpl.java 42.50% <83.33%> (+18.97%) 7.00 <2.00> (+2.00)
... and 53 more

Claudio Mezzasalma added 4 commits April 9, 2020 10:34
Signed-off-by: Claudio Mezzasalma <claudio.mezzasalma@eurotech.com>
Signed-off-by: Claudio Mezzasalma <claudio.mezzasalma@eurotech.com>
Signed-off-by: Claudio Mezzasalma <claudio.mezzasalma@eurotech.com>
Signed-off-by: Claudio Mezzasalma <claudio.mezzasalma@eurotech.com>
@lorthirk lorthirk force-pushed the change-findByFieldImprovements branch from 60e7ff2 to 08bef72 Compare April 9, 2020 08:35
@lorthirk lorthirk marked this pull request as ready for review April 9, 2020 10:20
@Coduz Coduz merged commit e287be3 into eclipse-kapua:develop Apr 17, 2020
@lorthirk lorthirk deleted the change-findByFieldImprovements branch May 8, 2020 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement This PR/Issue improves an part of Kapua
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants