-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ServiceDAO findByField improvements #2930
Merged
Coduz
merged 5 commits into
eclipse-kapua:develop
from
lorthirk:change-findByFieldImprovements
Apr 17, 2020
Merged
ServiceDAO findByField improvements #2930
Coduz
merged 5 commits into
eclipse-kapua:develop
from
lorthirk:change-findByFieldImprovements
Apr 17, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lorthirk
changed the title
Change find by field improvements
ServiceDAO findByField improvements
Apr 7, 2020
lorthirk
force-pushed
the
change-findByFieldImprovements
branch
from
April 7, 2020 14:26
dc1a666
to
7cc720a
Compare
Coduz
requested changes
Apr 7, 2020
service/job/internal/src/main/java/org/eclipse/kapua/service/job/step/internal/JobStepDAO.java
Outdated
Show resolved
Hide resolved
service/job/internal/src/main/java/org/eclipse/kapua/service/job/internal/JobDAO.java
Outdated
Show resolved
Hide resolved
...internal/src/main/java/org/eclipse/kapua/service/job/execution/internal/JobExecutionDAO.java
Outdated
Show resolved
Hide resolved
...ce/account/internal/src/main/java/org/eclipse/kapua/service/account/internal/AccountDAO.java
Outdated
Show resolved
Hide resolved
.../job/internal/src/main/java/org/eclipse/kapua/service/job/targets/internal/JobTargetDAO.java
Outdated
Show resolved
Hide resolved
service/user/internal/src/main/java/org/eclipse/kapua/service/user/internal/UserDAO.java
Outdated
Show resolved
Hide resolved
service/user/internal/src/main/java/org/eclipse/kapua/service/user/internal/UserDAO.java
Outdated
Show resolved
Hide resolved
commons/src/main/java/org/eclipse/kapua/commons/configuration/ServiceConfigDAO.java
Outdated
Show resolved
Hide resolved
commons/src/main/java/org/eclipse/kapua/commons/service/internal/ServiceDAO.java
Show resolved
Hide resolved
lorthirk
force-pushed
the
change-findByFieldImprovements
branch
from
April 7, 2020 16:08
22eb86f
to
933bcab
Compare
Coduz
approved these changes
Apr 7, 2020
Signed-off-by: Claudio Mezzasalma <claudio.mezzasalma@eurotech.com>
lorthirk
force-pushed
the
change-findByFieldImprovements
branch
2 times, most recently
from
April 8, 2020 15:55
d7a516f
to
32bad67
Compare
Codecov Report
@@ Coverage Diff @@
## develop #2930 +/- ##
=============================================
+ Coverage 54.30% 55.97% +1.66%
- Complexity 2381 2522 +141
=============================================
Files 1040 1040
Lines 22600 22621 +21
Branches 2039 2043 +4
=============================================
+ Hits 12272 12661 +389
+ Misses 9414 9025 -389
- Partials 914 935 +21 |
Signed-off-by: Claudio Mezzasalma <claudio.mezzasalma@eurotech.com>
Signed-off-by: Claudio Mezzasalma <claudio.mezzasalma@eurotech.com>
Signed-off-by: Claudio Mezzasalma <claudio.mezzasalma@eurotech.com>
Signed-off-by: Claudio Mezzasalma <claudio.mezzasalma@eurotech.com>
lorthirk
force-pushed
the
change-findByFieldImprovements
branch
from
April 9, 2020 08:35
60e7ff2
to
08bef72
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends
ServiceDAO.findByField()
to all fields, and also adds optionalscopeId
checkingRelated Issue
No related issue