Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added JUnit tests for SystemUtils class #2943

Merged
merged 1 commit into from
Apr 24, 2020
Merged

Added JUnit tests for SystemUtils class #2943

merged 1 commit into from
Apr 24, 2020

Conversation

code-incubus
Copy link
Contributor

Signed-off-by: code-incubus nemanja.milutinovic@comtrade.com

Added JUnit tests for the SystemUtils class.

Related Issue
None

Description of the solution adopted
No description needed.

Screenshots
/

Any side note on the changes made
/

Copy link
Contributor

@LeoNerdoG LeoNerdoG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@code-incubus, I have checked this PR and there are some changes to be made.
Please address the changes and then push branch once again.

Thanks!

Signed-off-by: code-incubus <nemanja.milutinovic@comtrade.com>
Copy link
Contributor

@LeoNerdoG LeoNerdoG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Coduz,
I have checekd this PR and it looks OK. Can you please merge it when CI and tests pass? Thanks!

@codecov
Copy link

codecov bot commented Apr 22, 2020

Codecov Report

Merging #2943 into develop will increase coverage by 0.49%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #2943      +/-   ##
=============================================
+ Coverage      55.23%   55.73%   +0.49%     
- Complexity      2554     2558       +4     
=============================================
  Files           1048     1048              
  Lines          22810    22810              
  Branches        2051     2051              
=============================================
+ Hits           12599    12713     +114     
+ Misses          9253     9147     -106     
+ Partials         958      950       -8     
Impacted Files Coverage Δ Complexity Δ
...e/kapua/service/user/internal/UserFactoryImpl.java 54.54% <0.00%> (-9.10%) 4.00% <0.00%> (-1.00%)
.../DeviceManagementNotificationMessageProcessor.java 64.28% <0.00%> (-7.15%) 0.00% <0.00%> (ø%)
...a/org/eclipse/kapua/commons/model/id/KapuaEid.java 75.00% <0.00%> (-6.25%) 0.00% <0.00%> (ø%)
.../eclipse/kapua/service/user/internal/UserImpl.java 70.27% <0.00%> (-5.41%) 16.00% <0.00%> (-1.00%)
...rvice/device/registry/common/DeviceValidation.java 71.25% <0.00%> (-2.50%) 14.00% <0.00%> (-1.00%)
...apua/job/engine/jbatch/JobEngineServiceJbatch.java 51.85% <0.00%> (-1.86%) 8.00% <0.00%> (-1.00%)
...pse/kapua/commons/service/internal/ServiceDAO.java 74.67% <0.00%> (-0.33%) 0.00% <0.00%> (ø%)
...onfiguration/AbstractKapuaConfigurableService.java 80.90% <0.00%> (+0.90%) 0.00% <0.00%> (ø%)
...e/kapua/job/engine/jbatch/driver/JbatchDriver.java 70.07% <0.00%> (+2.36%) 21.00% <0.00%> (ø%)
...se/kapua/commons/configuration/ValueTokenizer.java 43.20% <0.00%> (+2.40%) 0.00% <0.00%> (ø%)
... and 19 more

@Coduz Coduz marked this pull request as draft April 22, 2020 14:57
@LeoNerdoG
Copy link
Contributor

Hi @Coduz,
this PR is no longer work in progress, it is done.
All the checks have passed successfully, so can you please merge it?

@Coduz Coduz added the Test Test related stuff. It's a dirty job, but someone needs to do that! label Apr 24, 2020
@Coduz Coduz marked this pull request as ready for review April 24, 2020 08:35
@Coduz Coduz merged commit 72d06e2 into eclipse-kapua:develop Apr 24, 2020
@code-incubus code-incubus deleted the JUnitTests-SystemUtils branch May 4, 2020 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Test Test related stuff. It's a dirty job, but someone needs to do that!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants