-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added JUnit tests for SystemUtils class #2943
Added JUnit tests for SystemUtils class #2943
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@code-incubus, I have checked this PR and there are some changes to be made.
Please address the changes and then push branch once again.
Thanks!
Signed-off-by: code-incubus <nemanja.milutinovic@comtrade.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Coduz,
I have checekd this PR and it looks OK. Can you please merge it when CI and tests pass? Thanks!
Codecov Report
@@ Coverage Diff @@
## develop #2943 +/- ##
=============================================
+ Coverage 55.23% 55.73% +0.49%
- Complexity 2554 2558 +4
=============================================
Files 1048 1048
Lines 22810 22810
Branches 2051 2051
=============================================
+ Hits 12599 12713 +114
+ Misses 9253 9147 -106
+ Partials 958 950 -8 |
Hi @Coduz, |
Signed-off-by: code-incubus nemanja.milutinovic@comtrade.com
Added JUnit tests for the SystemUtils class.
Related Issue
None
Description of the solution adopted
No description needed.
Screenshots
/
Any side note on the changes made
/