Added Junit Tests for SemanticVersion #2946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sonja <sonja.matic@comtrade.com>
Codecov Report
@@ Coverage Diff @@
## develop #2946 +/- ##
=============================================
+ Coverage 55.23% 55.74% +0.51%
- Complexity 2554 2557 +3
=============================================
Files 1048 1048
Lines 22810 22810
Branches 2051 2051
=============================================
+ Hits 12599 12716 +117
+ Misses 9253 9148 -105
+ Partials 958 946 -12 |
Coduz
approved these changes
Apr 24, 2020
Coduz
added
the
Test
LeoNerdoG
pushed a commit
to LeoNerdoG/kapua
that referenced
this pull request
May 5, 2020
With a fix for a certain REST API bug (preventing users to change their account settings) in PR eclipse-kapua#2946 and PR eclipse-kapua#2954 the unit tests for services (tags, users, jobs, scheduling,...) started to fail. I have fixed this by introducing a mocked account that is used as basis for the service creation. I have already ran PR on my Travis and everything was fine. CodeCov should report 0% increased/decreased coverage, since all the changes made are in the ignored folders. Signed-off-by: Leonardo Gaube <leonardo.gaube@comtrade.com> **Related Issue** This PR fixes problems with unit tests in PR eclipse-kapua#2947 and PR eclipse-kapua#2954. **Description of the solution adopted:** I have added a mocked AccountService and mocked AccountFactory classes to the existing unit tests, so that the check does not fail. This is achieved with Mockito's "spy" method. The necessary Account methods are injected in the _CucumberWithProeprtiesFor(Service)_ file. @lorthirk can you please look at the solution adopted and see if it's ok? After you merge this PR into develop, just rebase your PRs to develop and the tests should be passing normally. **Screenshots** N/A **Any side note on the changes made** N/A Signed-off-by: Leonardo Gaube <leonardo.gaube@comtrade.com>
LeoNerdoG
pushed a commit
to LeoNerdoG/kapua
that referenced
this pull request
May 5, 2020
With a fix for a certain REST API bug (preventing users to change their account settings) in PR eclipse-kapua#2946 and PR eclipse-kapua#2954 the unit tests for services (tags, users, jobs, scheduling,...) started to fail. I have fixed this by introducing a mocked account that is used as basis for the service creation. I have already ran PR on my Travis and everything was fine. CodeCov should report 0% increased/decreased coverage, since all the changes made are in the ignored folders. Signed-off-by: Leonardo Gaube <leonardo.gaube@comtrade.com> **Related Issue** This PR fixes problems with unit tests in PR eclipse-kapua#2947 and PR eclipse-kapua#2954. **Description of the solution adopted:** I have added a mocked AccountService and mocked AccountFactory classes to the existing unit tests, so that the check does not fail. This is achieved with Mockito's "spy" method. The necessary Account methods are injected in the _CucumberWithProeprtiesFor(Service)_ file. @lorthirk can you please look at the solution adopted and see if it's ok? After you merge this PR into develop, just rebase your PRs to develop and the tests should be passing normally. **Screenshots** N/A **Any side note on the changes made** N/A Signed-off-by: Leonardo Gaube <leonardo.gaube@comtrade.com>
LeoNerdoG
pushed a commit
to LeoNerdoG/kapua
that referenced
this pull request
May 5, 2020
With a fix for a certain REST API bug (preventing users to change their account settings) in PR eclipse-kapua#2946 and PR eclipse-kapua#2954 the unit tests for services (tags, users, jobs, scheduling,...) started to fail. I have fixed this by introducing a mocked account that is used as basis for the service creation. I have already ran PR on my Travis and everything was fine. CodeCov should report 0% increased/decreased coverage, since all the changes made are in the ignored folders. Signed-off-by: Leonardo Gaube <leonardo.gaube@comtrade.com> **Related Issue** This PR fixes problems with unit tests in PR eclipse-kapua#2947 and PR eclipse-kapua#2954. **Description of the solution adopted:** I have added a mocked AccountService and mocked AccountFactory classes to the existing unit tests, so that the check does not fail. This is achieved with Mockito's "spy" method. The necessary Account methods are injected in the _CucumberWithProeprtiesFor(Service)_ file. @lorthirk can you please look at the solution adopted and see if it's ok? After you merge this PR into develop, just rebase your PRs to develop and the tests should be passing normally. **Screenshots** N/A **Any side note on the changes made** N/A
LeoNerdoG
pushed a commit
to LeoNerdoG/kapua
that referenced
this pull request
May 5, 2020
With a fix for a certain REST API bug (preventing users to change their account settings) in PR eclipse-kapua#2946 and PR eclipse-kapua#2954 the unit tests for services (tags, users, jobs, scheduling,...) started to fail. I have fixed this by introducing a mocked account that is used as basis for the service creation. I have already ran PR on my Travis and everything was fine. CodeCov should report 0% increased/decreased coverage, since all the changes made are in the ignored folders. Signed-off-by: Leonardo Gaube <leonardo.gaube@comtrade.com> **Related Issue** This PR fixes problems with unit tests in PR eclipse-kapua#2947 and PR eclipse-kapua#2954. **Description of the solution adopted:** I have added a mocked AccountService and mocked AccountFactory classes to the existing unit tests, so that the check does not fail. This is achieved with Mockito's "spy" method. The necessary Account methods are injected in the _CucumberWithProeprtiesFor(Service)_ file. @lorthirk can you please look at the solution adopted and see if it's ok? After you merge this PR into develop, just rebase your PRs to develop and the tests should be passing normally. **Screenshots** N/A **Any side note on the changes made** N/A
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sonja sonja.matic@comtrade.com
Added Junit Tests for SemanticVersion