-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Further translator refactoring and optimization #2956
Merged
Coduz
merged 8 commits into
eclipse-kapua:develop
from
Coduz:feature-translatorRefactoring
Apr 29, 2020
Merged
Further translator refactoring and optimization #2956
Coduz
merged 8 commits into
eclipse-kapua:develop
from
Coduz:feature-translatorRefactoring
Apr 29, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: coduz <alberto.codutti@eurotech.com>
…ranslators Signed-off-by: coduz <alberto.codutti@eurotech.com>
…ycle Signed-off-by: coduz <alberto.codutti@eurotech.com>
Signed-off-by: coduz <alberto.codutti@eurotech.com>
…Kapua Signed-off-by: coduz <alberto.codutti@eurotech.com>
…ications Signed-off-by: coduz <alberto.codutti@eurotech.com>
…tions Signed-off-by: coduz <alberto.codutti@eurotech.com>
…cations Signed-off-by: coduz <alberto.codutti@eurotech.com>
Coduz
force-pushed
the
feature-translatorRefactoring
branch
from
April 28, 2020 14:16
6e4454d
to
14e85d4
Compare
Codecov Report
@@ Coverage Diff @@
## develop #2956 +/- ##
=============================================
+ Coverage 55.62% 55.82% +0.19%
- Complexity 2552 2555 +3
=============================================
Files 1048 1044 -4
Lines 22810 22692 -118
Branches 2051 2036 -15
=============================================
- Hits 12688 12667 -21
+ Misses 9176 9095 -81
+ Partials 946 930 -16
|
lorthirk
approved these changes
Apr 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR follows and completes work done in #2876 with improved code and removal of some duplicated code.
Related Issue
This PR integrates changes made in #2876
Description of the solution adopted
Where possible refactored code to make reuse of logic.
Removed
UnmatchedMessage
s classes which were no longer used.Screenshots
None
Any side note on the changes made
None