Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Further translator refactoring and optimization #2956

Merged
merged 8 commits into from
Apr 29, 2020

Conversation

Coduz
Copy link
Contributor

@Coduz Coduz commented Apr 28, 2020

This PR follows and completes work done in #2876 with improved code and removal of some duplicated code.

Related Issue
This PR integrates changes made in #2876

Description of the solution adopted
Where possible refactored code to make reuse of logic.
Removed UnmatchedMessages classes which were no longer used.

Screenshots
None

Any side note on the changes made
None

@Coduz Coduz added the Enhancement This PR/Issue improves an part of Kapua label Apr 28, 2020
@Coduz Coduz requested a review from lorthirk April 28, 2020 13:33
Coduz added 8 commits April 28, 2020 16:16
Signed-off-by: coduz <alberto.codutti@eurotech.com>
…ranslators

Signed-off-by: coduz <alberto.codutti@eurotech.com>
…ycle

Signed-off-by: coduz <alberto.codutti@eurotech.com>
Signed-off-by: coduz <alberto.codutti@eurotech.com>
…Kapua

Signed-off-by: coduz <alberto.codutti@eurotech.com>
…ications

Signed-off-by: coduz <alberto.codutti@eurotech.com>
…tions

Signed-off-by: coduz <alberto.codutti@eurotech.com>
…cations

Signed-off-by: coduz <alberto.codutti@eurotech.com>
@Coduz Coduz force-pushed the feature-translatorRefactoring branch from 6e4454d to 14e85d4 Compare April 28, 2020 14:16
@codecov
Copy link

codecov bot commented Apr 28, 2020

Codecov Report

Merging #2956 into develop will increase coverage by 0.19%.
The diff coverage is 50.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #2956      +/-   ##
=============================================
+ Coverage      55.62%   55.82%   +0.19%     
- Complexity      2552     2555       +3     
=============================================
  Files           1048     1044       -4     
  Lines          22810    22692     -118     
  Branches        2051     2036      -15     
=============================================
- Hits           12688    12667      -21     
+ Misses          9176     9095      -81     
+ Partials         946      930      -16     
Impacted Files Coverage Δ Complexity Δ
...ua/broker/core/listener/DeviceMessageListener.java 60.46% <ø> (+3.01%) 0.00 <0.00> (ø)
...pua/broker/core/listener/ErrorMessageListener.java 79.16% <ø> (+17.87%) 0.00 <0.00> (ø)
.../kapua/broker/core/plugin/ConnectorDescriptor.java 100.00% <ø> (ø) 0.00 <0.00> (ø)
...re/plugin/DefaultConnectorDescriptionProvider.java 98.33% <ø> (-0.06%) 0.00 <0.00> (ø)
...ce/lifecycle/KapuaLifecycleMessageFactoryImpl.java 46.15% <ø> (+8.65%) 0.00 <0.00> (ø)
.../service/device/call/kura/app/SnapshotMetrics.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...e/kura/lifecycle/AbstractKuraAppsBirthChannel.java 100.00% <ø> (ø) 1.00 <0.00> (ø)
...e/kura/lifecycle/AbstractKuraAppsBirthMessage.java 100.00% <ø> (ø) 1.00 <0.00> (ø)
...e/kura/lifecycle/AbstractKuraAppsBirthPayload.java 35.41% <ø> (ø) 30.00 <0.00> (ø)
...e/kura/lifecycle/AbstractKuraLifecyclePayload.java 100.00% <ø> (ø) 1.00 <0.00> (?)
... and 46 more

@Coduz Coduz merged commit d66b506 into eclipse-kapua:develop Apr 29, 2020
@Coduz Coduz deleted the feature-translatorRefactoring branch April 29, 2020 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement This PR/Issue improves an part of Kapua
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants