Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed input parameters definition for device/packages/_download #2960

Merged
merged 2 commits into from
May 5, 2020

Conversation

Coduz
Copy link
Contributor

@Coduz Coduz commented May 4, 2020

This PR fix the definition of input parameters for REST resource device/{deviceId}/packages/_download which was missing some properties.

Related Issue
None

Description of the solution adopted
Added the definitions of missing properties.

Screenshots
None

Any side note on the changes made
None

Signed-off-by: coduz <alberto.codutti@eurotech.com>
@Coduz Coduz added Bug This is a bug or an unexpected behaviour. Fix it! REST API We hope to REST everyday Documentation Doc... What?? Joke! We will write some! labels May 4, 2020
@Coduz Coduz requested a review from lorthirk May 4, 2020 10:04
Signed-off-by: coduz <alberto.codutti@eurotech.com>
@Coduz Coduz marked this pull request as ready for review May 4, 2020 13:11
@Coduz
Copy link
Contributor Author

Coduz commented May 4, 2020

Basic request example:
Screen Shot 2020-05-04 at 3 11 29 PM

Full request example:
Screen Shot 2020-05-04 at 3 11 36 PM

@Coduz Coduz removed the Bug This is a bug or an unexpected behaviour. Fix it! label May 4, 2020
@codecov
Copy link

codecov bot commented May 4, 2020

Codecov Report

Merging #2960 into develop will increase coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #2960      +/-   ##
=============================================
+ Coverage      56.29%   56.36%   +0.07%     
- Complexity      2590     2597       +7     
=============================================
  Files           1059     1059              
  Lines          22975    22975              
  Branches        2061     2061              
=============================================
+ Hits           12934    12951      +17     
+ Misses          9093     9080      -13     
+ Partials         948      944       -4     
Impacted Files Coverage Δ Complexity Δ
...obDeviceManagementOperationManagerServiceImpl.java 73.17% <0.00%> (-6.10%) 13.00% <0.00%> (-1.00%)
...atch/persistence/jpa/JpaExecutionInstanceData.java 87.80% <0.00%> (-2.44%) 22.00% <0.00%> (-1.00%)
.../jbatch/persistence/JPAPersistenceManagerImpl.java 31.60% <0.00%> (+1.03%) 30.00% <0.00%> (ø%)
...nnection/internal/DeviceConnectionServiceImpl.java 69.66% <0.00%> (+2.24%) 17.00% <0.00%> (+1.00%)
...apua/job/engine/jbatch/JobEngineServiceJbatch.java 53.70% <0.00%> (+3.70%) 8.00% <0.00%> (ø%)
.../DeviceManagementNotificationMessageProcessor.java 71.42% <0.00%> (+7.14%) 0.00% <0.00%> (ø%)
.../DeviceManagementOperationRegistryServiceImpl.java 73.21% <0.00%> (+7.14%) 16.00% <0.00%> (+4.00%)
...lugin/authentication/AdminAuthenticationLogic.java 76.92% <0.00%> (+7.69%) 0.00% <0.00%> (ø%)
...rtz/persistence/KapuaQuartzConnectionProvider.java 100.00% <0.00%> (+12.50%) 5.00% <0.00%> (+1.00%)
...ob/engine/jbatch/exception/JobEngineException.java 66.66% <0.00%> (+33.33%) 2.00% <0.00%> (+1.00%)
... and 2 more

@Coduz Coduz merged commit 70b6f1f into eclipse-kapua:develop May 5, 2020
@Coduz Coduz deleted the fix-devicePackageDownloadOpenAPI branch May 5, 2020 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Doc... What?? Joke! We will write some! REST API We hope to REST everyday
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants