Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ssoException in broker docker container #2966

Merged
merged 2 commits into from
May 6, 2020

Conversation

gbarbon
Copy link
Contributor

@gbarbon gbarbon commented May 5, 2020

The broker image is not able to start since there is a missing dependency on SsoException.
Exception: java.lang.ClassNotFoundException: org.eclipse.kapua.sso.exception.SsoException.

Related Issue
N/A

Description of the solution adopted
Unused realms, like ApiKeyAuthenticatingRealm and JwtAuthenticatingRealm, have been removed from broker/core/src/main/resources/shiro.ini.
Also, kapua-sso-provider has been removed assembly/broker/pom.xml.

Screenshots
N/A

Any side note on the changes made
N/A

@gbarbon gbarbon marked this pull request as ready for review May 5, 2020 13:22
@Coduz Coduz self-requested a review May 5, 2020 14:24
@Coduz Coduz added the Bug This is a bug or an unexpected behaviour. Fix it! label May 5, 2020
Copy link
Contributor

@Coduz Coduz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the shiro.ini to not include JWT realms

@gbarbon gbarbon force-pushed the fix-brokerSsoException branch from 7b26496 to f3a9cac Compare May 5, 2020 15:02
@gbarbon
Copy link
Contributor Author

gbarbon commented May 5, 2020

Please fix the shiro.ini to not include JWT realms

Done!

@gbarbon gbarbon requested a review from Coduz May 5, 2020 15:06
gbarbon added 2 commits May 5, 2020 17:15
Signed-off-by: Gianluca Barbon <gianluca.barbon@eurotech.com>
Signed-off-by: Gianluca Barbon <gianluca.barbon@eurotech.com>
@gbarbon gbarbon force-pushed the fix-brokerSsoException branch from f3a9cac to 7e447f0 Compare May 5, 2020 15:15
@codecov
Copy link

codecov bot commented May 5, 2020

Codecov Report

Merging #2966 into develop will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #2966      +/-   ##
=============================================
+ Coverage      56.27%   56.32%   +0.04%     
- Complexity      2591     2593       +2     
=============================================
  Files           1061     1061              
  Lines          22990    22990              
  Branches        2065     2065              
=============================================
+ Hits           12938    12948      +10     
+ Misses          9100     9091       -9     
+ Partials         952      951       -1     
Impacted Files Coverage Δ Complexity Δ
...rtz/persistence/KapuaQuartzConnectionProvider.java 87.50% <0.00%> (-12.50%) 4.00% <0.00%> (-1.00%)
...pse/kapua/broker/core/pool/JmsConsumerWrapper.java 60.00% <0.00%> (-10.00%) 0.00% <0.00%> (ø%)
...pse/kapua/commons/service/internal/ServiceDAO.java 74.41% <0.00%> (-0.34%) 0.00% <0.00%> (ø%)
...nnection/internal/DeviceConnectionServiceImpl.java 69.66% <0.00%> (+2.24%) 17.00% <0.00%> (+1.00%)
.../DeviceManagementOperationRegistryServiceImpl.java 69.64% <0.00%> (+3.57%) 14.00% <0.00%> (+2.00%)
...ce/management/commons/call/DeviceCallExecutor.java 67.44% <0.00%> (+4.65%) 0.00% <0.00%> (ø%)
...obDeviceManagementOperationManagerServiceImpl.java 79.26% <0.00%> (+6.09%) 14.00% <0.00%> (+1.00%)
...ua/broker/core/listener/DeviceMessageListener.java 67.44% <0.00%> (+6.97%) 0.00% <0.00%> (ø%)

@Coduz Coduz merged commit 23f6eae into eclipse-kapua:develop May 6, 2020
@gbarbon gbarbon deleted the fix-brokerSsoException branch May 11, 2020 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug This is a bug or an unexpected behaviour. Fix it!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants