Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed failed redirect with sso logout #2970

Merged
merged 1 commit into from
May 13, 2020

Conversation

gbarbon
Copy link
Contributor

@gbarbon gbarbon commented May 11, 2020

With some SSO providers, the logout might fail to redirect to the Kapua login page. This is due to the access_token being used as id_token_hint parameter with the OpenID Connect logout endpoint. The id_token must be used instead.

Related Issue
N/A

Description of the solution adopted
The id_token is now used as id_token_hint parameter. Changes have been made to the console in order to retrieve and store the id_token, and then to use it when building the logout URI.

Screenshots
N/A

Any side note on the changes made
N/A

Signed-off-by: Gianluca Barbon <gianluca.barbon@eurotech.com>
@codecov
Copy link

codecov bot commented May 11, 2020

Codecov Report

Merging #2970 into develop will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #2970      +/-   ##
=============================================
+ Coverage      56.19%   56.22%   +0.03%     
- Complexity      2591     2593       +2     
=============================================
  Files           1061     1061              
  Lines          23002    23002              
  Branches        2064     2064              
=============================================
+ Hits           12926    12934       +8     
+ Misses          9123     9114       -9     
- Partials         953      954       +1     
Impacted Files Coverage Δ Complexity Δ
...pua/broker/core/listener/ErrorMessageListener.java 70.83% <0.00%> (-8.34%) 0.00% <0.00%> (ø%)
...apua/job/engine/jbatch/JobEngineServiceJbatch.java 51.85% <0.00%> (+1.85%) 8.00% <0.00%> (ø%)
.../DeviceManagementNotificationMessageProcessor.java 71.42% <0.00%> (+7.14%) 0.00% <0.00%> (ø%)
...lugin/authentication/AdminAuthenticationLogic.java 76.92% <0.00%> (+7.69%) 0.00% <0.00%> (ø%)
...ob/engine/jbatch/exception/JobEngineException.java 66.66% <0.00%> (+33.33%) 2.00% <0.00%> (+1.00%)
.../engine/jbatch/exception/JobStartingException.java 100.00% <0.00%> (+100.00%) 1.00% <0.00%> (+1.00%)

@Coduz Coduz added Bug This is a bug or an unexpected behaviour. Fix it! Console GWT This issue/PR is related to Admin Web Console labels May 13, 2020
@Coduz Coduz merged commit 0caafbb into eclipse-kapua:develop May 13, 2020
@gbarbon gbarbon deleted the fix-ssoLogoutIssue branch June 22, 2020 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug This is a bug or an unexpected behaviour. Fix it! Console GWT This issue/PR is related to Admin Web Console
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants