Sort order parameter for data messages request #2981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #2981 +/- ##
=============================================
+ Coverage 56.90% 57.04% +0.14%
- Complexity 2596 2602 +6
=============================================
Files 1062 1062
Lines 22978 22978
Branches 2043 2043
=============================================
+ Hits 13075 13108 +33
+ Misses 8942 8909 -33
Partials 961 961 |
lorthirk
requested changes
May 18, 2020
There was a problem hiding this comment.
Thanks for the submission @xshiart!
I would kindly ask for a few changes, and also it would be great if you could update the OpenAPI specification under rest-api/resources/src/main/resources/openapi.
I'll gladly merge this as soon as it's ready!
...i/resources/src/main/java/org/eclipse/kapua/app/api/resources/v1/resources/DataMessages.java
Outdated
Show resolved
Hide resolved
lorthirk
reviewed
May 18, 2020
...sources/src/main/java/org/eclipse/kapua/app/api/resources/v1/resources/DataMessagesJson.java
Outdated
Show resolved
Hide resolved
lorthirk
approved these changes
May 19, 2020
lorthirk
requested changes
May 19, 2020
rest-api/resources/src/main/resources/openapi/dataMessage/dataMessage-scopeId.yaml
Outdated
Show resolved
Hide resolved
Coduz
approved these changes
May 19, 2020
lorthirk
requested changes
May 19, 2020
rest-api/resources/src/main/resources/openapi/dataMessage/dataMessage-scopeId.yaml
Outdated
Show resolved
Hide resolved
Signed-off-by: Artem Shilin <xshiart@protonmail.com>
|
All looks good so I'll proceed to merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new parameter for /data/messages endpoint to control the sorting order of returned results.
This change improves REST API usage in case of iterating over messages.