Cache manager review the cache instantiation process #3011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…antiated caches) Signed-off-by: riccardomodanese <riccardo.modanese@eurotech.com>
commons/src/main/java/org/eclipse/kapua/commons/service/internal/cache/KapuaCacheManager.java
Show resolved
Hide resolved
stefanomorson
approved these changes
Jul 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: riccardomodanese riccardo.modanese@eurotech.com
Brief description of the PR.
Keep CachingProvider and CacheManager instance reference in KapuaCacheManager class
Related Issue
none
Description of the solution adopted
The process to create a cache instance involves the creation of a CachingProvider and a CacheManager.
The previous implementation creates a new instance of both of them for each cache instantiation.
Now the CachingProvider and CacheManager are instantiated once and kept as reference for the further getCache invocations.
This is perfectly allowed and shouldn't change any cache behavior since from CachingProvider.getCacheManager method javadoc (JCache specification):
"Requests a CacheManager configured according to the implementation specific URI that uses the provided ClassLoader for loading underlying classes.
Multiple calls to this method with the same URI and ClassLoader must return the same CacheManager instance, except if a previously returned CacheManager has been closed."
Screenshots
none
Any side note on the changes made
none