Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manage Device Packages Log Button Enabled Status #3054

Merged
merged 2 commits into from
Aug 26, 2020

Conversation

lorthirk
Copy link

This PR fixes the Enabled/Disabled status of the Device Packages --> History --> Log button

Related Issue
Fixes #2868

@lorthirk lorthirk added Bug This is a bug or an unexpected behaviour. Fix it! Console GWT This issue/PR is related to Admin Web Console labels Aug 14, 2020
@lorthirk lorthirk requested a review from Coduz August 14, 2020 15:39
@codecov
Copy link

codecov bot commented Aug 14, 2020

Codecov Report

Merging #3054 into develop will decrease coverage by 0.57%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #3054      +/-   ##
=============================================
- Coverage      57.79%   57.22%   -0.58%     
+ Complexity      2596     2539      -57     
=============================================
  Files           1061     1061              
  Lines          22874    22874              
  Branches        2028     2028              
=============================================
- Hits           13221    13090     -131     
- Misses          8710     8837     +127     
- Partials         943      947       +4     
Impacted Files Coverage Δ Complexity Δ
...inition/internal/JobStepDefinitionCreatorImpl.java 0.00% <0.00%> (-89.48%) 0.00% <0.00%> (-11.00%)
.../engine/jbatch/exception/JobResumingException.java 0.00% <0.00%> (-50.00%) 0.00% <0.00%> (-1.00%)
...step/definition/internal/JobStepDefinitionDAO.java 11.11% <0.00%> (-50.00%) 2.00% <0.00%> (-1.00%)
...tep/definition/internal/JobStepDefinitionImpl.java 22.58% <0.00%> (-48.39%) 6.00% <0.00%> (-7.00%)
.../service/job/step/internal/JobStepServiceImpl.java 37.50% <0.00%> (-39.43%) 11.00% <0.00%> (-10.00%)
...ob/execution/internal/JobExecutionServiceImpl.java 64.51% <0.00%> (-35.49%) 10.00% <0.00%> (-5.00%)
...ob/engine/jbatch/exception/JobEngineException.java 33.33% <0.00%> (-33.34%) 1.00% <0.00%> (-1.00%)
...pse/kapua/service/job/internal/JobFactoryImpl.java 37.50% <0.00%> (-25.00%) 3.00% <0.00%> (-2.00%)
...ob/execution/internal/JobExecutionFactoryImpl.java 37.50% <0.00%> (-25.00%) 3.00% <0.00%> (-2.00%)
...se/kapua/service/job/step/internal/JobStepDAO.java 58.82% <0.00%> (-23.53%) 3.00% <0.00%> (-3.00%)
... and 20 more

@LeoNerdoG
Copy link
Contributor

hey @lorthirk, I have checked this and "log" button gets enabled if user connects a live device and goes to Packages -> History and clicks Install button and without filling the fileds clicks "Cancel". Can you please check?

@LeoNerdoG
Copy link
Contributor

@lorthirk I have checked this PR again and now it is OK. It can be merged into develop.

Claudio Mezzasalma added 2 commits August 26, 2020 12:18
Signed-off-by: Claudio Mezzasalma <claudio.mezzasalma@eurotech.com>
Signed-off-by: Claudio Mezzasalma <claudio.mezzasalma@eurotech.com>
@lorthirk lorthirk force-pushed the fix-manageLogButtonEnabled branch from 8802ee4 to 6fc62f2 Compare August 26, 2020 10:18
@Coduz Coduz removed Bug This is a bug or an unexpected behaviour. Fix it! Console GWT This issue/PR is related to Admin Web Console labels Aug 26, 2020
@Coduz Coduz merged commit c5a2b50 into eclipse-kapua:develop Aug 26, 2020
@lorthirk lorthirk deleted the fix-manageLogButtonEnabled branch August 26, 2020 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Log" Button Not Active in Devices -> Packages
3 participants