Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(jobEngine): added missing mappings in JobEngine locator.xml for DeviceConnectionService and DeviceConnectionFactory #3852

Conversation

Coduz
Copy link
Contributor

@Coduz Coduz commented Aug 25, 2023

This PR fixes mapping of Job Engine locator.xml.

DeviceConnectionService and DeviceConnectionFactory were not added when backporting #3697

Related Issue
This PR fixes backport issue on #3697

Description of the solution adopted
Added missing mappings to the Job Engine locator.xml.

Screenshots
None

Any side note on the changes made
None

…eviceConnectionService and DeviceConnectionFactory

Signed-off-by: Alberto Codutti <alberto.codutti@eurotech.com>
@Coduz Coduz added the Bug This is a bug or an unexpected behaviour. Fix it! label Aug 25, 2023
@codecov
Copy link

codecov bot commented Aug 25, 2023

Codecov Report

Merging #3852 (ca11c6c) into release-1.7.x (14ddff7) will decrease coverage by 0.01%.
The diff coverage is n/a.

❗ Current head ca11c6c differs from pull request most recent head 929afe5. Consider uploading reports for the commit 929afe5 to get more accurate results

Impacted file tree graph

@@                 Coverage Diff                 @@
##             release-1.7.x    #3852      +/-   ##
===================================================
- Coverage            53.76%   53.75%   -0.01%     
+ Complexity             877      874       -3     
===================================================
  Files                 1601     1601              
  Lines                32095    32095              
  Branches              2672     2672              
===================================================
- Hits                 17256    17253       -3     
- Misses               13851    13854       +3     
  Partials               988      988              

see 14 files with indirect coverage changes

@Coduz Coduz merged commit 2e8b164 into eclipse-kapua:release-1.7.x Aug 28, 2023
@Coduz Coduz deleted the fix-deviceConnectionServiceAndFactoryMissingMappings branch August 31, 2023 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug This is a bug or an unexpected behaviour. Fix it!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant