Fix broker crash on 1.6.x due to missing dependency
#3901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the codebase both `commons-lang:commons-lang` and `org.apache.commons:commons-lang3` are used, but the first were missing from the dependency.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release-1.6.x #3901 +/- ##
===================================================
- Coverage 54.03% 53.93% -0.11%
+ Complexity 879 876 -3
===================================================
Files 1587 1587
Lines 31950 31950
Branches 2663 2663
===================================================
- Hits 17264 17231 -33
- Misses 13707 13734 +27
- Partials 979 985 +6 |
Coduz
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the missing dependency
commons-lang:commons-langinto thebroker.In the codebase both
commons-lang:commons-langandorg.apache.commons:commons-lang3are used, but the first were missing from the dependency.In a future PR it might be useful to port all the code to
org.apache.commons:commons-lang3.Related Issue
This PR fixes #3900.