Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(datastore): improve performances on messages store #3915

Merged
merged 1 commit into from
Dec 6, 2023

Conversation

riccardomodanese
Copy link
Contributor

@riccardomodanese riccardomodanese commented Dec 5, 2023

Brief description of the PR.
This pr introduces a parameter to tune the datastore driver behaviour on message storing.

Related Issue
none

Description of the solution adopted
A new parameter allows to set the type of check the datastore does about the message uniqueness on message storing.

  • NONE no checks are made
  • BOUND check is made only in the index of the account where the message should be stored based on the current indexing policy
  • FULL check is made in all the indices of the account (current and default)

Depepending on the use case this parameter enhance the flexibility.

Screenshots
none

Any side note on the changes made
none (the default value for this parameter let the datastore to work as before so no changes in the datastore behaviour using the default value

Copy link

codecov bot commented Dec 5, 2023

Codecov Report

Merging #3915 (c5eb2b0) into develop (5c0ea6c) will increase coverage by 0.10%.
Report is 8 commits behind head on develop.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #3915      +/-   ##
=============================================
+ Coverage      20.51%   20.62%   +0.10%     
  Complexity         6        6              
=============================================
  Files           1945     1946       +1     
  Lines          41660    41697      +37     
  Branches        3946     3951       +5     
=============================================
+ Hits            8548     8598      +50     
+ Misses         32715    32700      -15     
- Partials         397      399       +2     
Files Coverage Δ
...tastore/internal/model/MessageUniquenessCheck.java 0.00% <0.00%> (ø)
...e/internal/mediator/MessageStoreConfiguration.java 38.46% <0.00%> (-4.10%) ⬇️
...service/datastore/internal/MessageStoreFacade.java 0.00% <0.00%> (ø)

... and 9 files with indirect coverage changes

@riccardomodanese riccardomodanese force-pushed the fix-datastorePerformances branch from aa693b3 to 7cfbf78 Compare December 5, 2023 12:59
@riccardomodanese riccardomodanese force-pushed the fix-datastorePerformances branch 2 times, most recently from e47e2df to 09f1d9f Compare December 5, 2023 15:16
Signed-off-by: riccardomodanese <riccardo.modanese@eurotech.com>
@riccardomodanese riccardomodanese force-pushed the fix-datastorePerformances branch from 09f1d9f to c5eb2b0 Compare December 5, 2023 15:43
@Coduz Coduz added the Bug This is a bug or an unexpected behaviour. Fix it! label Dec 6, 2023
@Coduz Coduz merged commit 8d99fab into develop Dec 6, 2023
57 of 60 checks passed
@Coduz Coduz deleted the fix-datastorePerformances branch January 11, 2024 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug This is a bug or an unexpected behaviour. Fix it!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants