Remove unnecessary localization logic #4038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed unnecessary localization logic that dynamically set the locale based on request parameters to mitigate a XSS vulnerability. Since our system does not support multiple languages, replaced it with a static default locale of `en`.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #4038 +/- ##
=============================================
- Coverage 16.71% 16.67% -0.04%
Complexity 22 22
=============================================
Files 2009 2009
Lines 52223 52223
Branches 4437 4437
=============================================
- Hits 8728 8708 -20
- Misses 43092 43112 +20
Partials 403 403 |
Coduz
added
Bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request addresses an XSS vulnerability by removing unnecessary localization logic from the
console.jspfile. The original code dynamically set the locale based on request parameters, which could potentially be exploited by malicious users. Since our system does not support multiple languages, we replaced the dynamic logic with a static default locale of "en" to mitigate the XSS risk.