🐛 [User] Fixed bugs on duplicate external SSO users creation and update #4188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gic to find duplicate external users on datastore
Coduz
approved these changes
Feb 11, 2025
Coduz
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were some problems when trying to create an already existing external user with the same externalUsername parameter: the back-end was allowing the operation. Other than that, It was not possible to update an external username, for example changing its e-mail, because the back-end was complaining about an already present user in the system.
I solved the issue changing the Userservice accordingly: other than fixing a method reference to findByExternalId that needed to be findByExternalUsername, I fixed the logic of searching duplicate users by externalIds and externalUsernames