Use logging config from kuksa-python-sdk #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikbosch
force-pushed
the
erik_logging
branch
3 times, most recently
from
32f2ed2
to
4e2836b
Compare
erikbosch
commented
May 14, 2024
| @@ -65,7 +65,7 @@ def start(self): | |||
|
|
|||
| self._kuksa = KuksaClientThread(self._client_config) | |||
| self._kuksa.start() | |||
| self._kuksa.authorize() | |||
| self._kuksa.authorize(token_or_tokenfile=self._token_path) | |||
There was a problem hiding this comment.
Previously we did not consider what token was given in the config file, it worked anyway as kuksa-python-sdk had a default one which was the same one as we used in tests. This is an example on what we need to do to update client to latest kuksa-client. It should only affect VISS/websocket, but I assume we want to make sure thatw e support Websocket at least until end of year when Kuksa Server reaches end of life
Will require an updated kuksa-client to work
|
Some weird line breaks in log
Not sure it come from this PR, but do we want that? |
|
It does not come from this PR, it is from this code: https://github.com/eclipse-kuksa/kuksa-can-provider/blob/main/dbcfeeder.py#L306 |
SebastianSchildt
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses logging config from
kuksa-python-sdk.