Initial DevContainer setup #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #128 +/- ##
==========================================
+ Coverage 60.11% 60.14% +0.03%
==========================================
Files 33 33
Lines 16191 16191
==========================================
+ Hits 9733 9738 +5
+ Misses 6458 6453 -5 ☔ View full report in Codecov by Sentry. |
SebastianSchildt
force-pushed
the
devcontainer
branch
from
af3780a to
e0a3f3d
Compare
|
@mikehaller Attention if you keep working on this locally, I did a rebase, becasue I assume the linter errors might have been due to recently merged #129 |
|
Looking good to me, just not sure we should pdate Cargo.lock in here (this PR has changed nothing in Cargo, but changing it here, might be some rebasing trouble for the next PR actually needs to change it, like probably #119 ). Opinion @lukasmittag ? |
SebastianSchildt
approved these changes
Feb 3, 2025
lukasmittag
requested changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A DevContainer which shows how to set up the Rust compiler and tools to make the databroker build work in vscode out of the box.
I know devcontainers are subjective and some project members may not be in favour of such a "proprietary" setup. But it will help the adoption for developers in a corporate environment :-P