initial CSV-recorder #105
initial CSV-recorder #105
Conversation
eriksven
force-pushed
the
feature/csv-recorder
branch
from
ca00335
to
918d0de
Compare
csv_provider/README.md
Outdated
| | short argument | long argument | description | default value | | ||
| |---- | ---- | ----- | ----| | ||
| |-f| --file | This indicates the filename to which to write the VSS-signals. | signalsOut.csv | | ||
| |-s| --signals | A list of signals to record. | signalsOut.csv | | |
There was a problem hiding this comment.
Default is incorrect? Shall we mention how you specify multiple signals, i.e. one -s with multiple names separated by comma?
There was a problem hiding this comment.
I now extend the example call above to show how one can specify multiple signals even without the comma like in -s Vehicle.Speed Vehicle.Width. WDYT?
eriksven
force-pushed
the
feature/csv-recorder
branch
from
918d0de
to
9e7ec16
Compare
csv_provider/README.md
Outdated
| |-s| --signals | A list of signals to record. | There is no default value, but the argument is required.| | | ||
| | -a | --address | This indicates the address of `kuksa.val` databroker to connect to. | 127.0.0.1 | | ||
| | -p | --port | This indicates the port of the `kuksa.val` databroker to connect to. | 55555 | | ||
| | -l | --log | This sets the logging level. Possible values are: DEBUG, INFO, DEBUG, WARNING, ERROR, CRITICAL | INFO |
|
also one conflicting file I see |
csv_provider/recorder.py
Outdated
| def init_argparse() -> argparse.ArgumentParser: | ||
| '''This inits the argument parser for the CSV-recorder.''' | ||
| parser = argparse.ArgumentParser( | ||
| usage="-a [BROKER ADDRESS] -p [BROKER PORT] -f [FILE]", |
There was a problem hiding this comment.
Should -s and -l be listed on this line as well?
csv_provider/recorder.py
Outdated
| 'delay': time_gap}) | ||
| except VSSClientError as error: | ||
| logging.error("There was a problem in the interaction" | ||
| " with the Kuksa.val data broker at %s:%s: %s ", |
There was a problem hiding this comment.
Replace "data broker" with "Databroker", see https://github.com/eclipse/kuksa.val/wiki/KUKSA.val-Naming-Guidelines
There was a problem hiding this comment.
I will replace it to align, but personally I prefer 'data broker' since most language checkers ask for this writing and I do not think the term is unique enough to be a proper noun in the context of Eclipse Kuksa.
There was a problem hiding this comment.
I have no strong opinion on what we use as long as we are consistent. At the moment we mostly use "Databroker", in for example the README, but if we would agreed that "Data broker" would be better name I have no problem with that, but then we should change it "Data broker" in all free-text-places, and possibly use "data-broker" or "data_broker" as preferred name where blanks cannot be used, like directories and docker containers.
| @@ -7,7 +7,7 @@ The provider requires an installation of Python in version 3 and can be executed | |||
|
|
|||
| ``` | |||
| pip install -r requirements.txt | |||
| python provider.py | |||
| python3 provider.py | |||
There was a problem hiding this comment.
@SebastianSchildt - I have noticed that we are quite inconsistent regarding if we use python or python3 in our examples. We definitively cannot use "python2" but in most distros "python2" isn't available anyway, and it might be so that your python command anyway points to a python3 installation. We also likely do not support older 3.X-versions anyway.
But in short - do we prefer to use python or python3 in examples? If we agree on preferred term I have an idea of aligning the examples so that they all use the same term. A similar discussion exists for pip vs pip3.
There was a problem hiding this comment.
Personally I prefer python3 because I use it my own but no „strong“ opinion
There was a problem hiding this comment.
Just saw the MS Teams bot ate my answer, I wrote this
No strong opinion either. Asking me like this I'd prefer just "python", I do have a vague memory that some of the python3 where needed in the past, as the default was Py2 on some distros also used in containers. But that may have been ancient Ubuntu 16.04 times, so I'd be fine to use "pip" and "python", if container builds break we will see it. From user perspective, depending what environment they use, they can fall into a hole either way....
eriksven
force-pushed
the
feature/csv-recorder
branch
from
9e7ec16
to
906a802
Compare
eriksven
force-pushed
the
feature/csv-recorder
branch
from
906a802
to
065ac24
Compare
|
lgtm. |
Adds a script for recording files according to the format expected by the CSV-provider