This repository has been archived by the owner on Sep 2, 2024. It is now read-only.
Support input of multiple DBC files #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukasmittag
suggested changes
Jun 29, 2023
lukasmittag
approved these changes
Jun 30, 2023
lukasmittag
suggested changes
Jun 30, 2023
| self.db = cantools.database.load_file(filename, strict=use_strict_parsing) | ||
| first = False | ||
| else: | ||
| log.info("Adding definitions from {}".format(filename)) |
There was a problem hiding this comment.
here you need to check for found_names again, did a test and loading two files says it has loaded the same file but does it anyway after. Or you move the if firtst: .. else part into the else of if filename in found_names:
There was a problem hiding this comment.
Yes, right now it just gives a warning, it anyway loads it the second time. I can change so it only loads it once
lukasmittag
approved these changes
Jun 30, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.