Skip to content
This repository has been archived by the owner on Sep 2, 2024. It is now read-only.

Bugfix Mapper not iterable #114

Merged
merged 1 commit into from
Jul 3, 2023

Conversation

mikehaller
Copy link
Contributor

j1939reader is using the Mapper as a Iterable, but the functions were missing:

The fix makes the Mapper iterable, same change as in vss2ddsmapper.py (see https://github.com/eclipse/kuksa.val.feeders/blob/main/dds2val/ddsproviderlib/vss2ddsmapper.py#L117)

2023-06-30 06:36:56,452 WARNING dbcfeederlib.j1939reader: Error decoding message [PGN: CCVS]
Traceback (most recent call last):
  File "/workspaces/leda-example-applications-fork/canbus-j1939/kuksa.val.feeders/dbc2val/dbcfeederlib/j1939reader.py", line 76, in on_message
    if k in self.mapper:
TypeError: argument of type 'Mapper' is not iterable

j1939reader is using the Mapper as a Iterable, but the functions were missing.
@erikbosch
Copy link
Contributor

This is likely a regression from a refactoring, unfortunately we do not have any "public" J1939 test files (dump) that can be run as part of regression tests.

This works, an alternative solution would be to useself.mapper.get_dbc2val_mappings(k) like in dbcreader.py

@erikbosch erikbosch merged commit 333e0c9 into eclipse-kuksa:main Jul 3, 2023
@erikbosch erikbosch deleted the fix/j1939-mapper branch October 31, 2024 13:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants