Merge DBCParser into Mapper #138
Conversation
sophokles73
force-pushed
the
merge_parser_into_mapper
branch
3 times, most recently
from
6ef3a0b
to
ce85994
Compare
sophokles73
force-pushed
the
merge_parser_into_mapper
branch
from
ce85994
to
6fda436
Compare
| @@ -1,7 +1,7 @@ | |||
| #!/usr/bin/python3 | |||
|
|
|||
| ######################################################################## | |||
| # Copyright (c) 2020 Robert Bosch GmbH | |||
| # Copyright (c) 2020,2023 Robert Bosch GmbH | |||
There was a problem hiding this comment.
@SebastianSchildt - do we somewhere have any guidelines on how to handle "years" in copyright? As of today we have for dbcfeeder two types of license statements, one (like here) stating Bosch copyright, others have a more generic "Contributors to the Eclipse Foundation". Then for year, when shall we add a new year like here. Always?
Edit: I noticed that in https://www.eclipse.org/projects/handbook/#ip-copyright-headers they say
"Do I need to update the year in the copyright statement when I make changes to the file?"
"No. The year in the copyright header should be the year that the content was created."
There was a problem hiding this comment.
The same section also states for the newer copyright header's 1st line:
The year is expressed as a single year or a range spanning the year of the very initial assertion and that of the most recent change.
:-)
sophokles73
force-pushed
the
merge_parser_into_mapper
branch
3 times, most recently
from
cad7a50
to
e51a570
Compare
sophokles73
force-pushed
the
merge_parser_into_mapper
branch
from
e51a570
to
c21820b
Compare
The readers require a Mapper as well as information provided by the DBCParser. The Mapper itself also requires information from the parser. The Mapper has therefore been changed to use the DBCParser class as a mixin. The readers and the Feeder have been adapted accordingly.
sophokles73
force-pushed
the
merge_parser_into_mapper
branch
from
c21820b
to
d9ff2cf
Compare
| #!/usr/bin/python3 | ||
|
|
||
| ######################################################################## | ||
| # Copyright (c) 2023 Contributors to the Eclipse Foundation |
There was a problem hiding this comment.
Intentional to remove this file? - it was just added, right?
Or no longer needed as functionality integrated into test_readers folder?
There was a problem hiding this comment.
it's the latter :-)
The readers require a Mapper as well as information provided by the DBCParser. The Mapper itself also requires information from the parser.
The Mapper has therefore been changed to use the DBCParser class as a mixin. The readers and the Feeder have been adapted accordingly.